Bug 113225 - http://www.proprietariosdobrasil.org.br/ constantly reloads
Summary: http://www.proprietariosdobrasil.org.br/ constantly reloads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-25 11:03 PDT by Gustavo Noronha (kov)
Modified: 2014-04-25 07:28 PDT (History)
9 users (show)

See Also:


Attachments
Simple page to reproduce it easily. (315 bytes, text/html)
2014-04-11 22:49 PDT, Miyoung Shin
no flags Details
Patch (3.08 KB, patch)
2014-04-12 00:17 PDT, Miyoung Shin
no flags Details | Formatted Diff | Diff
Patch (5.79 KB, patch)
2014-04-24 08:45 PDT, Miyoung Shin
no flags Details | Formatted Diff | Diff
Patch for landing (5.63 KB, patch)
2014-04-24 16:53 PDT, Miyoung Shin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2013-03-25 11:03:25 PDT
SSIA, tested with both Epiphany with 1.11.92 WebKit2GTK+ and GtkLauncher master.
Comment 1 Dan Winship 2013-03-25 11:28:11 PDT
Since webkit handles redirection itself now, this is probably a ResourceHandleSoup problem, not a libsoup problem. Assuming it's related to HTTP redirection at all, rather than HTML/JS-based reloading.
Comment 2 Sergio Villar Senin 2013-03-27 12:29:28 PDT
Not a Soup or WebKitGtk+ bug per se as I can reproduce it with Chromium as well. There is something wrong in that page anyway because FF for example redirects to an "Error - Page not found"
Comment 3 Gustavo Noronha (kov) 2013-03-28 09:38:14 PDT
Fun! I thought it was specific to soup because I could not reproduce with Chrome.
Comment 4 Miyoung Shin 2014-04-08 07:40:25 PDT
Is there anyone to follow this issue ?
If not, can I pick this one ?

As I checked the CallStack, this problem is happened by touch event in WebCore.
But IOS will be OK, because they've implemented with different way.
Comment 5 Sergio Villar Senin 2014-04-08 08:28:56 PDT
(In reply to comment #4)
> Is there anyone to follow this issue ?
> If not, can I pick this one ?

Sure, go ahead.
Comment 6 Miyoung Shin 2014-04-11 22:49:00 PDT
Created attachment 229200 [details]
Simple page to reproduce it easily.
Comment 7 Miyoung Shin 2014-04-12 00:17:53 PDT
Created attachment 229201 [details]
Patch
Comment 8 Martin Robinson 2014-04-12 00:24:30 PDT
Can you explain how page reloading related to touch events?
Comment 9 Miyoung Shin 2014-04-12 00:45:54 PDT
Sorry, I don't catch your point because it's not related to reloading.

I think you can reproduce it easily on some browser based on WebKit except IOS as I attached a sample page,

It's very simple.

document.addEventListener(name, handler, true);
var event = document.createEvent('TouchEvent');    // <--  create TouchEvent
event.initTouchEvent(name);                                 // <--   there is not any attribute except event name
document.dispatchEvent(event);                           //  <--  but try to dispatch touch event


According to touch-event spec,
URL : www.w3.org/TR/touch-events/

==============================
5.1 Attributes
changedTouches of type TouchList, readonly
    a list of Touches for every point of contact which contributed to the event.
    For the touchstart event this must be a list of the touch points that just became active with the current event. For the touchmove event this must be a list of the touch points that have moved since the last event. For the touchend and touchcancel events this must be a list of the touch points that have just been removed from the surface.

targetTouches of type TouchList, readonly
    a list of Touches for every point of contact that is touching the surface and started on the element that is the target of the current event. 

touches of type TouchList, readonly
    a list of Touches for every point of contact currently touching the surface. 
==============================
I thought these attributes should be necessarily required in TouchEvent
Comment 10 Martin Robinson 2014-04-12 01:03:31 PDT
Perhaps you uploaded the patch to the wrong bug?
Comment 11 Martin Robinson 2014-04-12 01:05:14 PDT
(In reply to comment #9)
> Sorry, I don't catch your point because it's not related to reloading.

I'm a bit confused because the bug is "http://www.proprietariosdobrasil.org.br/ constantly reloads"
Comment 12 Miyoung Shin 2014-04-12 01:50:04 PDT
(In reply to comment #11)
> I'm a bit confused because the bug is "http://www.proprietariosdobrasil.org.br/ constantly reloads"

which of browser do you reproduce it ?
I think crash problem is effect to constantly reload. isn't it ?
Comment 13 Benjamin Poulain 2014-04-23 14:21:29 PDT
Comment on attachment 229201 [details]
Patch

Can you make a test for this?
Comment 14 Miyoung Shin 2014-04-24 08:45:42 PDT
Created attachment 230081 [details]
Patch
Comment 15 Miyoung Shin 2014-04-24 10:10:56 PDT
(In reply to comment #13)
> (From update of attachment 229201 [details])
> Can you make a test for this?

I've attached a test cast. Thank you for your feedback.
Comment 16 Benjamin Poulain 2014-04-24 15:01:11 PDT
Comment on attachment 230081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230081&action=review

> Source/WebCore/dom/EventDispatcher.cpp:466
> +    // TouchEvent should have own attributes of touches, targetTouches and changedTouches before dispatch.

This comment is redundant with the code.
Comment 17 Miyoung Shin 2014-04-24 16:53:32 PDT
Created attachment 230117 [details]
Patch for landing
Comment 18 WebKit Commit Bot 2014-04-25 07:28:52 PDT
Comment on attachment 230117 [details]
Patch for landing

Clearing flags on attachment: 230117

Committed r167805: <http://trac.webkit.org/changeset/167805>
Comment 19 WebKit Commit Bot 2014-04-25 07:28:58 PDT
All reviewed patches have been landed.  Closing bug.