Bug 113215 - Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType
Summary: Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: miletus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-25 09:44 PDT by miletus
Modified: 2013-03-26 09:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.80 KB, patch)
2013-03-25 10:24 PDT, miletus 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description miletus 2013-03-25 09:44:27 PDT 
In bug 93045 we removed PlatformEvent::GestureDoubleTap since now DoubleTap gesture
is implemented as a Tap gesture with tap_count = 2.

But in WebViewImpl::handleGestureEvent(), a PlatformEvent is built from the WebGestureEvent
regardless, even though the PlatfromEvent will never reach the WebCore. (DoubleTap in
our case, it is only handled in WebViewImpl for doube-tap-to-zoom).

And WebInpuEventConversion.cpp::PlatformGestureEventBuilder() will reach ASSERT_NOT_REACHED()
when WebInputEvent::GestureDoubleTap is passed in.

So the cleanest solution to me is to convert the WebGestureEvent::DoubleTap to a
PlatformEvent::NoType, this makes the conversion list from WebInputEvent to PlatformEvent
complete and we don't need a special handling for the DoubleTap event in WebViewImpl::handleGestureEvent()
Comment 1 miletus 2013-03-25 10:24:09 PDT 
Created attachment 194880 [details]
Patch
Comment 2 miletus 2013-03-25 10:26:26 PDT 
hi tonikitoo, would you mind taking a look at this ?
Comment 3 WebKit Review Bot 2013-03-26 09:07:35 PDT 
Comment on attachment 194880 [details]
Patch

Clearing flags on attachment: 194880

Committed r146894: <http://trac.webkit.org/changeset/146894>
Comment 4 WebKit Review Bot 2013-03-26 09:07:38 PDT 
All reviewed patches have been landed.  Closing bug.