RESOLVED FIXED 113215
Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType 
https://bugs.webkit.org/show_bug.cgi?id=113215
Summary Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType
miletus
Reported 2013-03-25 09:44:27 PDT
In bug 93045 we removed PlatformEvent::GestureDoubleTap since now DoubleTap gesture is implemented as a Tap gesture with tap_count = 2. But in WebViewImpl::handleGestureEvent(), a PlatformEvent is built from the WebGestureEvent regardless, even though the PlatfromEvent will never reach the WebCore. (DoubleTap in our case, it is only handled in WebViewImpl for doube-tap-to-zoom). And WebInpuEventConversion.cpp::PlatformGestureEventBuilder() will reach ASSERT_NOT_REACHED() when WebInputEvent::GestureDoubleTap is passed in. So the cleanest solution to me is to convert the WebGestureEvent::DoubleTap to a PlatformEvent::NoType, this makes the conversion list from WebInputEvent to PlatformEvent complete and we don't need a special handling for the DoubleTap event in WebViewImpl::handleGestureEvent()
Attachments
Patch (2.80 KB, patch)
2013-03-25 10:24 PDT, miletus 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
miletus
Comment 1 2013-03-25 10:24:09 PDT
Created attachment 194880 [details] Patch
miletus
Comment 2 2013-03-25 10:26:26 PDT
hi tonikitoo, would you mind taking a look at this ?
WebKit Review Bot
Comment 3 2013-03-26 09:07:35 PDT
Comment on attachment 194880 [details] Patch Clearing flags on attachment: 194880 Committed r146894: <http://trac.webkit.org/changeset/146894>
WebKit Review Bot
Comment 4 2013-03-26 09:07:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.