Bug 113212 - [GTK] [gyp] Add support for building the platform directory
Summary: [GTK] [gyp] Add support for building the platform directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 113213
  Show dependency tree / graph
 
Reported: 2013-03-25 09:25 PDT by Martin Robinson
Modified: 2013-03-25 11:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.85 KB, patch)
2013-03-25 09:35 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-03-25 09:25:52 PDT 
The platform directory holds the implementation of the platform layer.
Comment 1 Martin Robinson 2013-03-25 09:35:14 PDT 
Created attachment 194871 [details]
Patch
Comment 2 Nico Weber 2013-03-25 11:00:56 PDT 
Comment on attachment 194871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194871&action=review

> Source/WebCore/ChangeLog:10
> +        of Chromium.

FYI: We use so many platforms in chromium due to the windows linker running out of memory otherwise (we have to use the 32 bit linker).

If you don't need to support windows, you might be able to do with fewer targets if you like.
Comment 3 Martin Robinson 2013-03-25 11:05:09 PDT 
(In reply to comment #2)

> FYI: We use so many platforms in chromium due to the windows linker running out of memory otherwise (we have to use the 32 bit linker).
> 
> If you don't need to support windows, you might be able to do with fewer targets if you like.

We manage to have this same issue downstream on 32-bit systems as well. :(
Comment 4 Martin Robinson 2013-03-25 11:21:39 PDT 
Comment on attachment 194871 [details]
Patch

Clearing flags on attachment: 194871

Committed r146789: <http://trac.webkit.org/changeset/146789>
Comment 5 Martin Robinson 2013-03-25 11:21:41 PDT 
All reviewed patches have been landed.  Closing bug.