Bug 113189 - Web Inspector: [Timeline] set glue records mode off by default
Summary: Web Inspector: [Timeline] set glue records mode off by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-25 05:00 PDT by Andrey Kosyakov
Modified: 2013-03-25 07:45 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2013-03-25 05:02 PDT, Andrey Kosyakov 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64 (1.06 MB, application/zip)
2013-03-25 06:51 PDT, WebKit Review Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2013-03-25 05:00:07 PDT 
In glue records, if inspected page produces excessive asynchronous events that get glued (e.g. repeated setTimeout()'s), timeline may exhibit O(n^2) dependency on number of records. This is due to continuous updating of parent records stats. The mode is generally seen as confusing, so turn it off by default.
Comment 1 Andrey Kosyakov 2013-03-25 05:02:35 PDT 
Created attachment 194831 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-25 06:51:51 PDT 
Comment on attachment 194831 [details]
Patch

Attachment 194831 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17122961

New failing tests:
inspector/timeline/timeline-receive-response-event.html
Comment 3 WebKit Review Bot 2013-03-25 06:51:55 PDT 
Created attachment 194845 [details]
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 4 Andrey Kosyakov 2013-03-25 07:45:02 PDT 
Committed r146771: <http://trac.webkit.org/changeset/146771>