Bug 113170 - WTF::binarySearchImpl() should compile with -Wshorten-64-to-32
Summary: WTF::binarySearchImpl() should compile with -Wshorten-64-to-32
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on:
Blocks: 107093
  Show dependency treegraph
Reported: 2013-03-24 21:05 PDT by David Kilzer (:ddkilzer)
Modified: 2013-03-25 08:27 PDT (History)
5 users (show)

See Also:

Patch v1 (1.56 KB, patch)
2013-03-24 21:10 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-03-24 21:05:48 PDT
/usr/local/include/wtf/StdLibExtras.h:190:30: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
        int pos = (size - 1) >> 1;
            ~~~   ~~~~~~~~~~~^~~~
1 error generated.
Comment 1 David Kilzer (:ddkilzer) 2013-03-24 21:10:36 PDT
Created attachment 194787 [details]
Patch v1
Comment 2 WebKit Review Bot 2013-03-25 08:27:52 PDT
Comment on attachment 194787 [details]
Patch v1

Clearing flags on attachment: 194787

Committed r146774: <http://trac.webkit.org/changeset/146774>
Comment 3 WebKit Review Bot 2013-03-25 08:27:55 PDT
All reviewed patches have been landed.  Closing bug.