Bug 113167 - [BlackBerry] add needReferer in WebPage load() api
Summary: [BlackBerry] add needReferer in WebPage load() api
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mary Wu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-24 19:51 PDT by Mary Wu
Modified: 2013-03-25 20:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.95 KB, patch)
2013-03-24 21:01 PDT, Mary Wu 		no flags Details | Formatted Diff | Diff
Patch (8.98 KB, patch)
2013-03-25 19:27 PDT, Mary Wu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mary Wu 2013-03-24 19:51:49 PDT 
Sometimes when client load request, it need to add referer with curren frame like save link/image in option menu, so we add needRef in load() interface in webpage.
Comment 1 Mary Wu 2013-03-24 21:01:57 PDT 
Created attachment 194785 [details]
Patch
Comment 2 Mary Wu 2013-03-25 03:01:00 PDT 
(In reply to comment #1)
> Created an attachment (id=194785) [details]
> Patch

internally reviewed by Joe Mason.
Comment 3 Rob Buis 2013-03-25 04:46:09 PDT 
Comment on attachment 194785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194785&action=review

LGTM.

> Source/WebKit/blackberry/ChangeLog:9
> +        Sometimes when client load request, it need to add referer with curren frame like

curren -> current.

> Source/WebKit/blackberry/ChangeLog:10
> +        save link/image in option menu, so we add needRef in load() interface in webpage.

Sounds like you need to add Joe Mason as internal reviewer.
Comment 4 Mary Wu 2013-03-25 19:06:24 PDT 
(In reply to comment #3)
> (From update of attachment 194785 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=194785&action=review
> 
> LGTM.
> 
> > Source/WebKit/blackberry/ChangeLog:9
> > +        Sometimes when client load request, it need to add referer with curren frame like
> 
> curren -> current.
> 
> > Source/WebKit/blackberry/ChangeLog:10
> > +        save link/image in option menu, so we add needRef in load() interface in webpage.
> 
> Sounds like you need to add Joe Mason as internal reviewer.

I thought I've added:p will update and push. thanks, Joe and Rob.
Comment 5 Mary Wu 2013-03-25 19:27:57 PDT 
Created attachment 194982 [details]
Patch
Comment 6 WebKit Review Bot 2013-03-25 20:15:31 PDT 
Comment on attachment 194982 [details]
Patch

Clearing flags on attachment: 194982

Committed r146845: <http://trac.webkit.org/changeset/146845>
Comment 7 WebKit Review Bot 2013-03-25 20:15:35 PDT 
All reviewed patches have been landed.  Closing bug.