Bug 113152 - [EFL] NetworkStateNotifier::updateState() is called too often
Summary: [EFL] NetworkStateNotifier::updateState() is called too often
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-24 06:07 PDT by Chris Dumez
Modified: 2013-03-24 07:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2013-03-24 06:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-03-24 06:07:15 PDT 
On my machine, NetworkStateNotifier::updateState() is called about 20 times per minute even though my network online state is not changing. Calling NetworkStateNotifier::updateState() is a bit expensive as it uses udev to iterate through all the network interfaces and check if they have an IP address set.

We should improve our NETLINK socket handling code a bit to avoid calling NetworkStateNotifier::updateState() uselessly as much as possible.
Comment 1 Chris Dumez 2013-03-24 06:15:01 PDT 
Created attachment 194746 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-24 07:47:20 PDT 
Comment on attachment 194746 [details]
Patch

Clearing flags on attachment: 194746

Committed r146728: <http://trac.webkit.org/changeset/146728>
Comment 3 WebKit Review Bot 2013-03-24 07:47:24 PDT 
All reviewed patches have been landed.  Closing bug.