Bug 113125 - testLeakingPrototypesAcrossContexts added in r146682 doesn't compile on Win and fails on Mac
Summary: testLeakingPrototypesAcrossContexts added in r146682 doesn't compile on Win a...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-22 20:17 PDT by Ryosuke Niwa
Modified: 2013-03-22 21:22 PDT (History)
3 users (show)

See Also:


Attachments
Removes the test for now (3.27 KB, patch)
2013-03-22 21:16 PDT, Ryosuke Niwa
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-03-22 20:17:25 PDT
http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/46467/steps/compile-webkit/logs/stdio

8>####### COMPILING 1 FILES USING AT MOST 8 PARALLEL INSTANCES OF cl.exe ###########
8>testapi.c
8>..\..\API\tests\testapi.c(146) : error C2332: 'class' : missing tag name
8>..\..\API\tests\testapi.c(146) : error C2236: unexpected 'class' '<unnamed-tag>'. Did you forget a ';'?
8>..\..\API\tests\testapi.c(149) : error C2332: 'class' : missing tag name
8>..\..\API\tests\testapi.c(149) : error C2226: syntax error : unexpected type '<unnamed-tag>'
8>..\..\API\tests\testapi.c(156) : error C2332: 'class' : missing tag name
8>..\..\API\tests\testapi.c(156) : error C2226: syntax error : unexpected type '<unnamed-tag>'
8>..\..\API\tests\testapi.c(169) : error C2664: 'nestedAllocateObject' : cannot convert parameter 2 from 'JSClassRef' to ''
8>        No constructor could take the source type, or constructor overload resolution was ambiguous

I've temporarily if-defed the test in http://trac.webkit.org/changeset/146707.
Comment 1 Ryosuke Niwa 2013-03-22 21:14:29 PDT
It seems like this test also fails on Mac:

http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/7233

FAIL: Failed to finalize the original object after the first GC.
PASS: Infinite prototype chain does not occur.
PASS: A cycle in a prototype chain can't be created.
FAIL: Some tests failed.
Comment 2 Ryosuke Niwa 2013-03-22 21:16:38 PDT
Created attachment 194689 [details]
Removes the test for now
Comment 3 Mark Hahnenberg 2013-03-22 21:17:20 PDT
Comment on attachment 194689 [details]
Removes the test for now

r=me
Comment 4 Ryosuke Niwa 2013-03-22 21:18:58 PDT
Thanks. Let me make sure it builds and land it.
Comment 5 Ryosuke Niwa 2013-03-22 21:22:39 PDT
Committed r146711: <http://trac.webkit.org/changeset/146711>