Bug 113104 - Dashboard refactor: Move cross dashboard history related code into history.js.
Summary: Dashboard refactor: Move cross dashboard history related code into history.js.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-22 15:12 PDT by Julie Parent
Modified: 2013-03-25 12:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (83.83 KB, patch)
2013-03-22 15:17 PDT, Julie Parent 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2013-03-22 15:12:44 PDT 
Dashboard refactor: Move cross dashboard history related code into history.js.
Comment 1 Julie Parent 2013-03-22 15:17:15 PDT 
Created attachment 194640 [details]
Patch
Comment 2 Ojan Vafai 2013-03-22 16:39:39 PDT 
Comment on attachment 194640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194640&action=review

> Tools/TestResultServer/static-dashboards/history.js:112
> +  this.crossDashboardState = {};
> +  this.dashboardSpecificState = {};

I think we eventually want to find a way to make these private as well. Only the History object should know about cross-dashboard vs. dashboard specific parameters. But, that's probably easier to do once the rest of this cleanup is further along.

> Tools/TestResultServer/static-dashboards/history.js:126
> +    parseCrossDashboardParameters: function()

We can make this private eventually too?
Comment 3 WebKit Review Bot 2013-03-25 12:40:12 PDT 
Comment on attachment 194640 [details]
Patch

Clearing flags on attachment: 194640

Committed r146797: <http://trac.webkit.org/changeset/146797>
Comment 4 WebKit Review Bot 2013-03-25 12:40:15 PDT 
All reviewed patches have been landed.  Closing bug.