RESOLVED FIXED 113100
Split ResourceHandleMac into multiple files 
https://bugs.webkit.org/show_bug.cgi?id=113100
Summary Split ResourceHandleMac into multiple files
Alexey Proskuryakov
Reported 2013-03-22 14:33:50 PDT
It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate substantially more complicated yet.
Attachments
proposed patch (56.45 KB, patch)
2013-03-22 14:40 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
with Windows fixes (57.51 KB, patch)
2013-03-22 15:22 PDT, Alexey Proskuryakov 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-03-22 14:40:06 PDT
Created attachment 194634 [details] proposed patch
WebKit Review Bot
Comment 2 2013-03-22 14:42:19 PDT
Attachment 194634 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/network/SynchronousLoaderClient.cpp', u'Source/WebCore/platform/network/SynchronousLoaderClient.h', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/platform/network/mac/SynchronousLoaderClient.mm', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm']" exit_code: 1 Source/WebCore/platform/network/SynchronousLoaderClient.h:29: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2013-03-22 15:22:34 PDT
Created attachment 194641 [details] with Windows fixes
Geoffrey Garen
Comment 4 2013-03-22 15:29:31 PDT
Comment on attachment 194641 [details] with Windows fixes r=me
WebKit Review Bot
Comment 5 2013-03-22 15:30:55 PDT
Attachment 194641 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/network/SynchronousLoaderClient.cpp', u'Source/WebCore/platform/network/SynchronousLoaderClient.h', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/platform/network/mac/SynchronousLoaderClient.mm', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm']" exit_code: 1 Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 6 2013-03-22 15:46:43 PDT
Committed <http://trac.webkit.org/r146667>.
Note You need to log in before you can comment on or make changes to this bug.