Bug 113100 - Split ResourceHandleMac into multiple files
Summary: Split ResourceHandleMac into multiple files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-22 14:33 PDT by Alexey Proskuryakov
Modified: 2013-03-22 15:46 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (56.45 KB, patch)
2013-03-22 14:40 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
with Windows fixes (57.51 KB, patch)
2013-03-22 15:22 PDT, Alexey Proskuryakov 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-03-22 14:33:50 PDT 
It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate substantially more complicated yet.
Comment 1 Alexey Proskuryakov 2013-03-22 14:40:06 PDT 
Created attachment 194634 [details]
proposed patch
Comment 2 WebKit Review Bot 2013-03-22 14:42:19 PDT 
Attachment 194634 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/network/SynchronousLoaderClient.cpp', u'Source/WebCore/platform/network/SynchronousLoaderClient.h', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/platform/network/mac/SynchronousLoaderClient.mm', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm']" exit_code: 1
Source/WebCore/platform/network/SynchronousLoaderClient.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2013-03-22 15:22:34 PDT 
Created attachment 194641 [details]
with Windows fixes
Comment 4 Geoffrey Garen 2013-03-22 15:29:31 PDT 
Comment on attachment 194641 [details]
with Windows fixes

r=me
Comment 5 WebKit Review Bot 2013-03-22 15:30:55 PDT 
Attachment 194641 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/network/SynchronousLoaderClient.cpp', u'Source/WebCore/platform/network/SynchronousLoaderClient.h', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/platform/network/mac/SynchronousLoaderClient.mm', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm']" exit_code: 1
Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alexey Proskuryakov 2013-03-22 15:46:43 PDT 
Committed <http://trac.webkit.org/r146667>.