Bug 113097 - lazyAttached nodes should not need to detach before attaching
Summary: lazyAttached nodes should not need to detach before attaching
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111644
  Show dependency treegraph
 
Reported: 2013-03-22 14:01 PDT by Eric Seidel (no email)
Modified: 2013-03-22 14:02 PDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-03-22 14:01:36 PDT
lazyAttached nodes should not need to detach before attaching

Right now lazyAttach functions exactly how moving from display: none -> display: whatever would.  The node is attached and marked as needing style resolve, but has no renderer.  Thus when we do resolve style for the node, we find that it now needs a renderer, and do a reattach.

reattach does a detach (of the full subtree under the node) followed by an attach (of the full subtree).

When we lazyAttach a whole document at once, we end up doing a full subtree walk for the detach, which really wasn't needed.