Bug 113088 - [CSS Shaders] Clamp css_MixColor before the blending and compositing steps
Summary: [CSS Shaders] Clamp css_MixColor before the blending and compositing steps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Vujovic
URL:
Keywords:
Depends on:
Blocks: 71392
  Show dependency treegraph
 
Reported: 2013-03-22 11:53 PDT by Max Vujovic
Modified: 2013-03-22 16:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch for Bots (9.93 KB, patch)
2013-03-22 11:59 PDT, Max Vujovic
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Vujovic 2013-03-22 11:53:00 PDT
The blending and compositing operations from the spec [1] expect that they are operating on valid color inputs, in the range [0.0, 1.0]. Thus, we should clamp the css_MixColor input to this range to avoid implementation-dependent behavior for invalid color input.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending
Comment 1 Max Vujovic 2013-03-22 11:59:35 PDT
Created attachment 194610 [details]
Patch for Bots

Running the bots.
Comment 2 Max Vujovic 2013-03-22 16:27:19 PDT
Comment on attachment 194610 [details]
Patch for Bots

Thanks Dean!
Comment 3 WebKit Review Bot 2013-03-22 16:58:30 PDT
Comment on attachment 194610 [details]
Patch for Bots

Clearing flags on attachment: 194610

Committed r146683: <http://trac.webkit.org/changeset/146683>
Comment 4 WebKit Review Bot 2013-03-22 16:58:33 PDT
All reviewed patches have been landed.  Closing bug.