Bug 113079 – Enable canvas.getContext("webgl") on Desktop Chrome

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Brandon Jones]

Chrome now passes the WebGL 1.0.1 conformance tests on desktops (not Android yet). As such it's eligible to start using the "webgl" context ID. 

Support for the "experimental-webgl" context ID should not be removed at this time to preserve compatibility with existing WebGL applications.

[Brandon Jones]

Created attachment 194588 [details]
Patch

[Dean Jackson]

It will probably be many many years before we can remove experimental-webgl. Also, since the other ports don't yet pass the testsuite, they should probably still only accept the experimental form.

[Dean Jackson]

Comment on attachment 194588 [details]
Patch

This patch looks perfect! But, it should have a test case :)

Shame it needs to be skipped everywhere other than chromium :(

[Dean Jackson]

Comment on attachment 194588 [details]
Patch

Even better, check in FAIL for the default results, and a PASS result for platform/chromium

[Brandon Jones]

Created attachment 194642 [details]
Patch

[Kenneth Russell]

Looks good to me. Dean can do the r+ honors.

[Dean Jackson]

Comment on attachment 194642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194642&action=review

Ha! I'm pretty sure what's good enough for Ken is good enough for me.

> LayoutTests/fast/canvas/webgl/wegl-unprefixed-context-id.html:17
> +if (!gl) {
> +  testFailed("context does not exist");
> +} else {
> +  testPassed("context exists");
> +}

Single line conditional {} style warning.

[Brandon Jones]

Created attachment 194650 [details]
Patch

[WebKit Review Bot]

Comment on attachment 194650 [details]
Patch

Rejecting attachment 194650 [details] from commit-queue.

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/webgl/wegl-unprefixed-context-id.html
fast/canvas/webgl/wegl-unprefixed-context-id.html
Full output: http://webkit-commit-queue.appspot.com/results/17132774

[WebKit Review Bot]

Created attachment 194682 [details]
Archive of layout-test-results from gce-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Brandon Jones]

Created attachment 194894 [details]
Patch

[Kenneth Russell]

Comment on attachment 194894 [details]
Patch

To be clear: the difference compared to the previous patch is the fixing of a typo in the name of the test.

[WebKit Review Bot]

Comment on attachment 194894 [details]
Patch

Clearing flags on attachment: 194894

Committed r146795: <http://trac.webkit.org/changeset/146795>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.