Chrome now passes the WebGL 1.0.1 conformance tests on desktops (not Android yet). As such it's eligible to start using the "webgl" context ID. Support for the "experimental-webgl" context ID should not be removed at this time to preserve compatibility with existing WebGL applications.
Created attachment 194588 [details] Patch
It will probably be many many years before we can remove experimental-webgl. Also, since the other ports don't yet pass the testsuite, they should probably still only accept the experimental form.
Comment on attachment 194588 [details] Patch This patch looks perfect! But, it should have a test case :) Shame it needs to be skipped everywhere other than chromium :(
Comment on attachment 194588 [details] Patch Even better, check in FAIL for the default results, and a PASS result for platform/chromium
Created attachment 194642 [details] Patch
Looks good to me. Dean can do the r+ honors.
Comment on attachment 194642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194642&action=review Ha! I'm pretty sure what's good enough for Ken is good enough for me. > LayoutTests/fast/canvas/webgl/wegl-unprefixed-context-id.html:17 > +if (!gl) { > + testFailed("context does not exist"); > +} else { > + testPassed("context exists"); > +} Single line conditional {} style warning.
Created attachment 194650 [details] Patch
Comment on attachment 194650 [details] Patch Rejecting attachment 194650 [details] from commit-queue. New failing tests: platform/chromium/virtual/gpu/fast/canvas/webgl/wegl-unprefixed-context-id.html fast/canvas/webgl/wegl-unprefixed-context-id.html Full output: http://webkit-commit-queue.appspot.com/results/17132774
Created attachment 194682 [details] Archive of layout-test-results from gce-cq-03 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: gce-cq-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Created attachment 194894 [details] Patch
Comment on attachment 194894 [details] Patch To be clear: the difference compared to the previous patch is the fixing of a typo in the name of the test.
Comment on attachment 194894 [details] Patch Clearing flags on attachment: 194894 Committed r146795: <http://trac.webkit.org/changeset/146795>
All reviewed patches have been landed. Closing bug.