RESOLVED FIXED 113072
[BlackBerry] Hit Test doesn't need to be active 
https://bugs.webkit.org/show_bug.cgi?id=113072
Summary [BlackBerry] Hit Test doesn't need to be active
gmak
Reported 2013-03-22 09:15:41 PDT
Should be read only in proximity detector
Attachments
Patch with changelog (2.39 KB, patch)
2013-03-22 10:25 PDT, gmak 		rwlbuis: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (2.32 KB, patch)
2013-03-22 10:46 PDT, gmak 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
gmak
Comment 1 2013-03-22 10:25:37 PDT
Created attachment 194583 [details] Patch with changelog
Rob Buis
Comment 2 2013-03-22 10:27:06 PDT
Comment on attachment 194583 [details] Patch with changelog Ok.
WebKit Review Bot
Comment 3 2013-03-22 10:29:20 PDT
Comment on attachment 194583 [details] Patch with changelog Rejecting attachment 194583 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 194583, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: it-queue Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/blackberry/WebKitSupport/ProximityDetector.cpp Hunk #1 FAILED at 79. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/ProximityDetector.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://webkit-commit-queue.appspot.com/results/17234570
gmak
Comment 4 2013-03-22 10:46:18 PDT
Created attachment 194592 [details] Patch
Rob Buis
Comment 5 2013-03-22 10:47:04 PDT
Comment on attachment 194592 [details] Patch Retrying.
WebKit Review Bot
Comment 6 2013-03-22 11:31:01 PDT
Comment on attachment 194592 [details] Patch Clearing flags on attachment: 194592 Committed r146634: <http://trac.webkit.org/changeset/146634>
WebKit Review Bot
Comment 7 2013-03-22 11:31:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.