Bug 113072 - [BlackBerry] Hit Test doesn't need to be active
Summary: [BlackBerry] Hit Test doesn't need to be active
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-22 09:15 PDT by gmak
Modified: 2013-03-22 11:31 PDT (History)
1 user (show)

See Also:

Attachments
Patch with changelog (2.39 KB, patch)
2013-03-22 10:25 PDT, gmak 		rwlbuis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (2.32 KB, patch)
2013-03-22 10:46 PDT, gmak 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gmak 2013-03-22 09:15:41 PDT 
Should be read only in proximity detector
Comment 1 gmak 2013-03-22 10:25:37 PDT 
Created attachment 194583 [details]
Patch with changelog
Comment 2 Rob Buis 2013-03-22 10:27:06 PDT 
Comment on attachment 194583 [details]
Patch with changelog

Ok.
Comment 3 WebKit Review Bot 2013-03-22 10:29:20 PDT 
Comment on attachment 194583 [details]
Patch with changelog

Rejecting attachment 194583 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 194583, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
it-queue

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/blackberry/WebKitSupport/ProximityDetector.cpp
Hunk #1 FAILED at 79.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/ProximityDetector.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://webkit-commit-queue.appspot.com/results/17234570
Comment 4 gmak 2013-03-22 10:46:18 PDT 
Created attachment 194592 [details]
Patch
Comment 5 Rob Buis 2013-03-22 10:47:04 PDT 
Comment on attachment 194592 [details]
Patch

Retrying.
Comment 6 WebKit Review Bot 2013-03-22 11:31:01 PDT 
Comment on attachment 194592 [details]
Patch

Clearing flags on attachment: 194592

Committed r146634: <http://trac.webkit.org/changeset/146634>
Comment 7 WebKit Review Bot 2013-03-22 11:31:04 PDT 
All reviewed patches have been landed.  Closing bug.