RESOLVED FIXED 113052
Web Inspector: FlameChart. Draw function names over flame chart bar if they fit into the bar. 
https://bugs.webkit.org/show_bug.cgi?id=113052
Summary Web Inspector: FlameChart. Draw function names over flame chart bar if they f...
Ilya Tikhonovsky
Reported 2013-03-22 06:36:40 PDT
patch to follow
Attachments
Patch (4.03 KB, patch)
2013-03-22 06:46 PDT, Ilya Tikhonovsky 		vsevik: review+
DetailsFormatted DiffDiff
screenshot (198.97 KB, image/png)
2013-03-22 07:04 PDT, Ilya Tikhonovsky 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2013-03-22 06:46:38 PDT
Created attachment 194531 [details] Patch
Ilya Tikhonovsky
Comment 2 2013-03-22 07:04:42 PDT
Created attachment 194532 [details] screenshot
Vsevolod Vlasov
Comment 3 2013-03-22 07:58:13 PDT
Comment on attachment 194531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194531&action=review > Source/WebCore/inspector/front-end/FlameChart.js:525 > + var textOffset = 3; paddingLeft? > Source/WebCore/inspector/front-end/FlameChart.js:528 > + this._dotsWidth = context.measureText("...").width; Ellipsis? \u2026 > Source/WebCore/inspector/front-end/FlameChart.js:562 > + _prepareTitle: function(context, title, maxSize) I would not trim left part by dot, you can just put as much as you could in there. > Source/WebCore/inspector/front-end/FlameChart.js:575 > + var minTextLength = 7; 4?
Ilya Tikhonovsky
Comment 4 2013-03-22 08:58:53 PDT
Committed r146619: <http://trac.webkit.org/changeset/146619>
Note You need to log in before you can comment on or make changes to this bug.