Bug 113036 - E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47
Summary: E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 111848
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-22 03:11 PDT by Dominique Leuenberger
Modified: 2014-09-10 13:26 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2013-03-22 06:00 PDT, Dominique Leuenberger
mrobinson: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominique Leuenberger 2013-03-22 03:11:54 PDT
the open Build Service cancels the build of webkitgtk 1.11.92 (raising known compiler errors causing larger issues or security issues) with:

E: webkitgtk3 missing-sentinel Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47

The compiler output for this build-root check was:

[24320s] Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp: In function 'void removeNonEmptyDirectory(const char*)':
[24320s] Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47:75: warning: missing sentinel in function call [-Wformat]

The code in question is:

        GOwnPtr<char> filePath(g_build_filename(directoryPath, fileName, 0)); 

=> (int) 0 is not to be used as sentinel in this case, but NULL should be the sentinel
(see also https://developer.gnome.org/glib/2.34/glib-Miscellaneous-Utility-Functions.html#g-build-filename :
gchar *             g_build_filename                    (const gchar *first_element,
                                                         ...);
... :	remaining elements in path, terminated by NULL


The commit introducing this warning into webkitgtk was:
http://trac.webkit.org/changeset/145528
Comment 1 Zan Dobersek 2013-03-22 03:24:09 PDT
Dominique will provide the patch.
Comment 2 Carlos Garcia Campos 2013-03-22 04:52:05 PDT
I blame the style checker :-/ sorry :-(
Comment 3 Dominique Leuenberger 2013-03-22 06:00:18 PDT
Created attachment 194524 [details]
Patch
Comment 4 Carlos Garcia Campos 2013-03-24 05:42:57 PDT
Comment on attachment 194524 [details]
Patch

This doesn't apply on trunk, because it depends on other patches not landed yet. I'll commit it manually in the stable branch.
Comment 5 Dominique Leuenberger 2014-09-10 13:26:53 PDT
These seems obsolete for a long time..