the open Build Service cancels the build of webkitgtk 1.11.92 (raising known compiler errors causing larger issues or security issues) with:
E: webkitgtk3 missing-sentinel Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47
The compiler output for this build-root check was:
[24320s] Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp: In function 'void removeNonEmptyDirectory(const char*)':
[24320s] Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47:75: warning: missing sentinel in function call [-Wformat]
The code in question is:
GOwnPtr<char> filePath(g_build_filename(directoryPath, fileName, 0));
=> (int) 0 is not to be used as sentinel in this case, but NULL should be the sentinel
(see also https://developer.gnome.org/glib/2.34/glib-Miscellaneous-Utility-Functions.html#g-build-filename :
gchar * g_build_filename (const gchar *first_element,
... : remaining elements in path, terminated by NULL
The commit introducing this warning into webkitgtk was:
Dominique will provide the patch.
I blame the style checker :-/ sorry :-(
Created attachment 194524 [details]
Comment on attachment 194524 [details]
This doesn't apply on trunk, because it depends on other patches not landed yet. I'll commit it manually in the stable branch.
These seems obsolete for a long time..