Bug 113023 - [Curl] Performance fix, avoid loading cookie file on every request.
Summary: [Curl] Performance fix, avoid loading cookie file on every request.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-22 02:02 PDT by peavo
Modified: 2013-03-22 16:11 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.14 KB, patch)
2013-03-22 02:21 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-03-22 02:02:40 PDT
We currently load the cookie file on every request, and when reading cookies from JavaScript, by using the option CURLOPT_COOKIEFILE.
This is very inefficient as the cookie file can get quite large, and file I/O is slow.
It is sufficient to load the cookie file on startup, as we use a shared cookie database between the requests.
Comment 1 peavo 2013-03-22 02:21:07 PDT
Created attachment 194481 [details]
Patch
Comment 2 Brent Fulgham 2013-03-22 09:20:52 PDT
Comment on attachment 194481 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2013-03-22 09:24:52 PDT
Comment on attachment 194481 [details]
Patch

Clearing flags on attachment: 194481

Committed r146621: <http://trac.webkit.org/changeset/146621>
Comment 4 WebKit Review Bot 2013-03-22 09:24:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 peavo 2013-03-22 16:11:16 PDT
(In reply to comment #2)
> (From update of attachment 194481 [details])
> r=me

Thanks for reviewing ;)