Bug 113006 - After switching to another space and back, video races to catch up with audio
Summary: After switching to another space and back, video races to catch up with audio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 22:58 PDT by Jer Noble
Modified: 2013-03-22 16:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2013-03-21 23:36 PDT, Jer Noble 		andersca: review+
Details | Formatted Diff | Diff
Patch (4.81 KB, patch)
2013-03-21 23:39 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-03-21 22:58:36 PDT 
After switching to another space and back, video races to catch up with audio
Comment 1 Jer Noble 2013-03-21 23:36:33 PDT 
Created attachment 194452 [details]
Patch
Comment 2 Jer Noble 2013-03-21 23:37:00 PDT 
<rdar://problem/12316429>
Comment 3 Jer Noble 2013-03-21 23:39:03 PDT 
Created attachment 194453 [details]
Patch
Comment 4 Anders Carlsson 2013-03-22 14:18:55 PDT 
Comment on attachment 194452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194452&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:284
> +    NSNotificationCenter* nc = [[NSWorkspace sharedWorkspace] notificationCenter];

Please use a more descriptive variable name here, like workspaceNotificationCenter.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3173
> +    [nc addObserver:self selector:@selector(_activeSpaceDidChange:) name:NSWorkspaceActiveSpaceDidChangeNotification object:nil];

Ditto.
Comment 5 Jer Noble 2013-03-22 16:18:40 PDT 
Committed r146673: <http://trac.webkit.org/changeset/146673>