Bug 112998 - [BlackBerry] Memory leak in UserMediaClientImpl
Summary: [BlackBerry] Memory leak in UserMediaClientImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 20:22 PDT by Xiaobo Wang
Modified: 2013-03-26 03:46 PDT (History)
7 users (show)

See Also:


Attachments
patch (2.33 KB, patch)
2013-03-21 21:09 PDT, Xiaobo Wang
no flags Details | Formatted Diff | Diff
patch (2.33 KB, patch)
2013-03-21 21:20 PDT, Xiaobo Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaobo Wang 2013-03-21 20:22:34 PDT
Should destroy itself in UserMediaClientImpl::pageDestroyed(), as other
XXClientBlackBerry did, like
GeolocationClientBlackBerry::geolocationDestroyed().
Comment 1 Xiaobo Wang 2013-03-21 21:09:21 PDT
Created attachment 194433 [details]
patch
Comment 2 WebKit Review Bot 2013-03-21 21:13:23 PDT
Attachment 194433 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp']" exit_code: 1
Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:113:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xiaobo Wang 2013-03-21 21:20:09 PDT
Created attachment 194435 [details]
patch

Tab replaced.
Comment 4 Xiaobo Wang 2013-03-21 21:21:21 PDT
Comment on attachment 194433 [details]
patch

OK
Comment 5 Xiaobo Wang 2013-03-21 21:21:42 PDT
Comment on attachment 194433 [details]
patch

OK
Comment 6 Rob Buis 2013-03-22 05:39:42 PDT
Comment on attachment 194435 [details]
patch

LGTM.
Comment 7 Charles Wei 2013-03-26 03:40:28 PDT
Comment on attachment 194435 [details]
patch

commit it.
Comment 8 WebKit Review Bot 2013-03-26 03:46:48 PDT
Comment on attachment 194435 [details]
patch

Clearing flags on attachment: 194435

Committed r146865: <http://trac.webkit.org/changeset/146865>
Comment 9 WebKit Review Bot 2013-03-26 03:46:52 PDT
All reviewed patches have been landed.  Closing bug.