Bug 112996 - [BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry
Summary: [BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientB...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-03-21 20:18 PDT by Xiaobo Wang
Modified: 2013-03-26 19:23 PDT (History)
4 users (show)

See Also:

patch (9.81 KB, patch)
2013-03-21 21:03 PDT, Xiaobo Wang
no flags Details | Formatted Diff | Diff
patch (3.35 KB, patch)
2013-03-26 04:11 PDT, Xiaobo Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaobo Wang 2013-03-21 20:18:59 PDT
NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(), but
not deleted anywhere.

Fix by creating an OwnPtr for it.
Comment 1 Xiaobo Wang 2013-03-21 21:03:21 PDT
Created attachment 194431 [details]

        PR 312552
        Internally Reviewed by Anthony Scian.

        Also fixed some webkit-style errors.
Comment 2 WebKit Review Bot 2013-03-21 21:06:35 PDT
Attachment 194431 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/Api/WebPage_p.h', u'Source/WebKit/blackberry/ChangeLog']" exit_code: 1
Source/WebKit/blackberry/Api/WebPage.cpp:3656:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/blackberry/Api/WebPage.cpp:5495:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xiaobo Wang 2013-03-26 04:11:39 PDT
Created attachment 195055 [details]

Revised to only include my change.
Comment 4 Rob Buis 2013-03-26 07:07:20 PDT
Comment on attachment 195055 [details]

Comment 5 WebKit Review Bot 2013-03-26 19:23:03 PDT
Comment on attachment 195055 [details]

Clearing flags on attachment: 195055

Committed r146960: <http://trac.webkit.org/changeset/146960>
Comment 6 WebKit Review Bot 2013-03-26 19:23:06 PDT
All reviewed patches have been landed.  Closing bug.