Bug 112972 – Support Quota API in Workers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alec Flett]

Support Quota API in Workers

[Alec Flett]

Created attachment 194360 [details]
Patch

[Alec Flett]

abarth@ - mind reviewing this one too? I'm not sure who else would be an appropriate reviewer here.

[Adam Barth]

Comment on attachment 194360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194360&action=review

> Source/WebCore/Modules/quota/WorkerNavigatorStorageQuota.h:56
> +    explicit WorkerNavigatorStorageQuota();

No need for explicit here.  The constructor doesn't take any arguments.

[WebKit Review Bot]

Comment on attachment 194360 [details]
Patch

Attachment 194360 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17242232

New failing tests:
fast/workers/worker-storagequota-query-usage.html
fast/workers/shared-worker-storagequota-query-usage.html

[WebKit Review Bot]

Created attachment 194375 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Build Bot]

Comment on attachment 194360 [details]
Patch

Attachment 194360 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17225540

New failing tests:
fast/workers/worker-storagequota-query-usage.html
fast/workers/shared-worker-storagequota-query-usage.html

[Build Bot]

Created attachment 194377 [details]
Archive of layout-test-results from webkit-ews-16

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: <class 'webkitpy.common.config.ports.MacWK2Port'>  Platform: Mac OS X 10.8.2

[Kinuko Yasuda]

Alec, can you add TestExpectations?  The new tests will fail on all platforms for now.

[Build Bot]

Comment on attachment 194360 [details]
Patch

Attachment 194360 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17287184

New failing tests:
fast/workers/worker-storagequota-query-usage.html
fast/workers/shared-worker-storagequota-query-usage.html

[Build Bot]

Created attachment 194446 [details]
Archive of layout-test-results from webkit-ews-06

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.8.2

[Alec Flett]

(Sorry there were two FIXME's - so now I've replaced them both with the new comment)

[Alec Flett]

(oops wrong bug)

[Alec Flett]

Created attachment 194685 [details]
Patch

[WebKit Review Bot]

Comment on attachment 194685 [details]
Patch

Attachment 194685 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17202682

New failing tests:
fast/text/international/danda-space.html

[WebKit Review Bot]

Created attachment 194688 [details]
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Alec Flett]

Created attachment 194732 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 194732 [details]
Patch for landing

Attachment 194732 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17297147

New failing tests:
fast/text/international/danda-space.html

[WebKit Review Bot]

Created attachment 194735 [details]
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[WebKit Review Bot]

Comment on attachment 194732 [details]
Patch for landing

Rejecting attachment 194732 [details] from commit-queue.

New failing tests:
fast/text/international/danda-space.html
Full output: http://webkit-commit-queue.appspot.com/results/17318053

[WebKit Review Bot]

Created attachment 194757 [details]
Archive of layout-test-results from gce-cq-04 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-04  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Alec Flett]

Created attachment 194784 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 194784 [details]
Patch for landing

Rejecting attachment 194784 [details] from commit-queue.

New failing tests:
fast/text/international/danda-space.html
Full output: http://webkit-commit-queue.appspot.com/results/17241303

[WebKit Review Bot]

Created attachment 194788 [details]
Archive of layout-test-results from gce-cq-03 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-03  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[WebKit Review Bot]

Comment on attachment 194784 [details]
Patch for landing

Attachment 194784 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17250442

New failing tests:
fast/css/font-family-pictograph.html

[WebKit Review Bot]

Created attachment 194789 [details]
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[WebKit Review Bot]

Comment on attachment 194784 [details]
Patch for landing

Clearing flags on attachment: 194784

Committed r146764: <http://trac.webkit.org/changeset/146764>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Joshua Bell]

Comment on attachment 194784 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=194784&action=review

> Source/WebCore/Target.pri:3316
> +            Modules/quota/NavigatorStorageQuota.idl \

Should this be WorkerNavigatorStorageQuota.idl ?