Bug 112972 - Support Quota API in Workers
Summary: Support Quota API in Workers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on: 112713
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-21 15:12 PDT by Alec Flett
Modified: 2013-03-25 16:02 PDT (History)
10 users (show)

See Also:


Attachments
Patch (18.75 KB, patch)
2013-03-21 15:17 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-05 (536.02 KB, application/zip)
2013-03-21 16:14 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from webkit-ews-16 (515.93 KB, application/zip)
2013-03-21 16:27 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-06 (664.93 KB, application/zip)
2013-03-21 22:59 PDT, Build Bot
no flags Details
Patch (27.33 KB, patch)
2013-03-22 20:26 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64 (1013.22 KB, application/zip)
2013-03-22 21:00 PDT, WebKit Review Bot
no flags Details
Patch for landing (27.33 KB, patch)
2013-03-23 20:52 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64 (548.82 KB, application/zip)
2013-03-23 21:28 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from gce-cq-04 for chromium-linux-x86_64 (984.77 KB, application/zip)
2013-03-24 10:06 PDT, WebKit Review Bot
no flags Details
Patch for landing (27.33 KB, patch)
2013-03-24 20:45 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cq-03 for chromium-linux-x86_64 (640.61 KB, application/zip)
2013-03-24 21:52 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64 (705.11 KB, application/zip)
2013-03-24 22:54 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2013-03-21 15:12:43 PDT
Support Quota API in Workers
Comment 1 Alec Flett 2013-03-21 15:17:09 PDT
Created attachment 194360 [details]
Patch
Comment 2 Alec Flett 2013-03-21 15:18:29 PDT
abarth@ - mind reviewing this one too? I'm not sure who else would be an appropriate reviewer here.
Comment 3 Adam Barth 2013-03-21 16:04:46 PDT
Comment on attachment 194360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194360&action=review

> Source/WebCore/Modules/quota/WorkerNavigatorStorageQuota.h:56
> +    explicit WorkerNavigatorStorageQuota();

No need for explicit here.  The constructor doesn't take any arguments.
Comment 4 WebKit Review Bot 2013-03-21 16:14:33 PDT
Comment on attachment 194360 [details]
Patch

Attachment 194360 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17242232

New failing tests:
fast/workers/worker-storagequota-query-usage.html
fast/workers/shared-worker-storagequota-query-usage.html
Comment 5 WebKit Review Bot 2013-03-21 16:14:36 PDT
Created attachment 194375 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 6 Build Bot 2013-03-21 16:27:10 PDT
Comment on attachment 194360 [details]
Patch

Attachment 194360 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17225540

New failing tests:
fast/workers/worker-storagequota-query-usage.html
fast/workers/shared-worker-storagequota-query-usage.html
Comment 7 Build Bot 2013-03-21 16:27:12 PDT
Created attachment 194377 [details]
Archive of layout-test-results from webkit-ews-16

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: <class 'webkitpy.common.config.ports.MacWK2Port'>  Platform: Mac OS X 10.8.2
Comment 8 Kinuko Yasuda 2013-03-21 16:50:05 PDT
Alec, can you add TestExpectations?  The new tests will fail on all platforms for now.
Comment 9 Build Bot 2013-03-21 22:59:42 PDT
Comment on attachment 194360 [details]
Patch

Attachment 194360 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17287184

New failing tests:
fast/workers/worker-storagequota-query-usage.html
fast/workers/shared-worker-storagequota-query-usage.html
Comment 10 Build Bot 2013-03-21 22:59:44 PDT
Created attachment 194446 [details]
Archive of layout-test-results from webkit-ews-06

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.8.2
Comment 11 Alec Flett 2013-03-22 10:39:30 PDT
(Sorry there were two FIXME's - so now I've replaced them both with the new comment)
Comment 12 Alec Flett 2013-03-22 10:39:51 PDT
(oops wrong bug)
Comment 13 Alec Flett 2013-03-22 20:26:03 PDT
Created attachment 194685 [details]
Patch
Comment 14 WebKit Review Bot 2013-03-22 21:00:25 PDT
Comment on attachment 194685 [details]
Patch

Attachment 194685 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17202682

New failing tests:
fast/text/international/danda-space.html
Comment 15 WebKit Review Bot 2013-03-22 21:00:32 PDT
Created attachment 194688 [details]
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 16 Alec Flett 2013-03-23 20:52:23 PDT
Created attachment 194732 [details]
Patch for landing
Comment 17 WebKit Review Bot 2013-03-23 21:28:28 PDT
Comment on attachment 194732 [details]
Patch for landing

Attachment 194732 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17297147

New failing tests:
fast/text/international/danda-space.html
Comment 18 WebKit Review Bot 2013-03-23 21:28:33 PDT
Created attachment 194735 [details]
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 19 WebKit Review Bot 2013-03-24 10:06:02 PDT
Comment on attachment 194732 [details]
Patch for landing

Rejecting attachment 194732 [details] from commit-queue.

New failing tests:
fast/text/international/danda-space.html
Full output: http://webkit-commit-queue.appspot.com/results/17318053
Comment 20 WebKit Review Bot 2013-03-24 10:06:08 PDT
Created attachment 194757 [details]
Archive of layout-test-results from gce-cq-04 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-04  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 21 Alec Flett 2013-03-24 20:45:07 PDT
Created attachment 194784 [details]
Patch for landing
Comment 22 WebKit Review Bot 2013-03-24 21:52:14 PDT
Comment on attachment 194784 [details]
Patch for landing

Rejecting attachment 194784 [details] from commit-queue.

New failing tests:
fast/text/international/danda-space.html
Full output: http://webkit-commit-queue.appspot.com/results/17241303
Comment 23 WebKit Review Bot 2013-03-24 21:52:18 PDT
Created attachment 194788 [details]
Archive of layout-test-results from gce-cq-03 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-03  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 24 WebKit Review Bot 2013-03-24 22:54:13 PDT
Comment on attachment 194784 [details]
Patch for landing

Attachment 194784 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17250442

New failing tests:
fast/css/font-family-pictograph.html
Comment 25 WebKit Review Bot 2013-03-24 22:54:20 PDT
Created attachment 194789 [details]
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 26 WebKit Review Bot 2013-03-25 06:44:50 PDT
Comment on attachment 194784 [details]
Patch for landing

Clearing flags on attachment: 194784

Committed r146764: <http://trac.webkit.org/changeset/146764>
Comment 27 WebKit Review Bot 2013-03-25 06:44:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 28 Joshua Bell 2013-03-25 16:02:50 PDT
Comment on attachment 194784 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=194784&action=review

> Source/WebCore/Target.pri:3316
> +            Modules/quota/NavigatorStorageQuota.idl \

Should this be WorkerNavigatorStorageQuota.idl ?