RESOLVED FIXED 112970
[Mac] Move NSOperationQueue out of NetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=112970
Summary [Mac] Move NSOperationQueue out of NetworkingContext
Alexey Proskuryakov
Reported 2013-03-21 14:46:57 PDT
I'm making NSOperationQueue more internal to ResourceHandle. Unlike with SchedulePairs that is part of public API, WebCore clients do not need explicit control over what queue ResourceHandle works on, they just want to avoid blocking main thread.
Attachments
proposed patch (9.26 KB, patch)
2013-03-21 14:53 PDT, Alexey Proskuryakov
beidson: review+
Alexey Proskuryakov
Comment 1 2013-03-21 14:53:57 PDT
Created attachment 194352 [details] proposed patch
Brady Eidson
Comment 2 2013-03-21 15:01:32 PDT
Comment on attachment 194352 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=194352&action=review > Source/WebCore/platform/network/ResourceHandle.cpp:160 > d->m_client = client; > } > > +#if !PLATFORM(MAC) > +void ResourceHandle::useRequest(const ResourceRequest&) > +{ > + // ResourceHandle never calls willSendRequestAsync() on these platforms yet. > + ASSERT_NOT_REACHED(); > +} > +#endif > + > ResourceRequest& ResourceHandle::firstRequest() > { > return d->m_firstRequest; What? > Source/WebCore/platform/network/ResourceHandle.h:200 > ResourceHandleClient* client() const; > void setClient(ResourceHandleClient*); > > + // Called as a response to ResourceHandleClient::willSendRequestAsync(). > + void useRequest(const ResourceRequest&); > + > void setDefersLoading(bool); > > #if PLATFORM(BLACKBERRY) > - void pauseLoad(bool); > + void pauseLoad(bool); // FIXME: how is this different from setDefersLoading()? > #endif > > void didChangePriority(ResourceLoadPriority); What?
Brady Eidson
Comment 3 2013-03-21 15:03:33 PDT
Comment on attachment 194352 [details] proposed patch r+ with the "WHAT?"s removed, which I understand were accidentally included in this patch
Alexey Proskuryakov
Comment 4 2013-03-21 15:57:47 PDT
Committed <http://trac.webkit.org/changeset/146536>. Yes, those changes were from the future.
Note You need to log in before you can comment on or make changes to this bug.