Bug 112970 – [Mac] Move NSOperationQueue out of NetworkingContext

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Alexey Proskuryakov]

I'm making NSOperationQueue more internal to ResourceHandle. Unlike with SchedulePairs that is part of public API, WebCore clients do not need explicit control over what queue ResourceHandle works on, they just want to avoid blocking main thread.

[Alexey Proskuryakov]

Created attachment 194352 [details]
proposed patch

[Brady Eidson]

Comment on attachment 194352 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194352&action=review

> Source/WebCore/platform/network/ResourceHandle.cpp:160
>      d->m_client = client;
>  }
>  
> +#if !PLATFORM(MAC)
> +void ResourceHandle::useRequest(const ResourceRequest&)
> +{
> +    // ResourceHandle never calls willSendRequestAsync() on these platforms yet.
> +    ASSERT_NOT_REACHED();
> +}
> +#endif
> +
>  ResourceRequest& ResourceHandle::firstRequest()
>  {
>      return d->m_firstRequest;

What?

> Source/WebCore/platform/network/ResourceHandle.h:200
>      ResourceHandleClient* client() const;
>      void setClient(ResourceHandleClient*);
>  
> +    // Called as a response to ResourceHandleClient::willSendRequestAsync().
> +    void useRequest(const ResourceRequest&);
> +
>      void setDefersLoading(bool);
>  
>  #if PLATFORM(BLACKBERRY)
> -    void pauseLoad(bool);
> +    void pauseLoad(bool); // FIXME: how is this different from setDefersLoading()?
>  #endif
>  
>      void didChangePriority(ResourceLoadPriority);

What?

[Brady Eidson]

Comment on attachment 194352 [details]
proposed patch

r+ with the "WHAT?"s removed, which I understand were accidentally included in this patch

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/146536>. Yes, those changes were from the future.