Bug 112960 - [BlackBerry] addSearchProvider shouldn't match the full host, only the server
Summary: [BlackBerry] addSearchProvider shouldn't match the full host, only the server
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 13:46 PDT by otcheung
Modified: 2013-03-21 14:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.37 KB, patch)
2013-03-21 13:48 PDT, otcheung
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2013-03-21 13:46:29 PDT
Use the getRegisteredDomain ftn to compare the target url and the security origin url.

Also, only dispatch the addsearchprovider event after we check user-gesture.
Comment 1 otcheung 2013-03-21 13:48:48 PDT
Created attachment 194326 [details]
Patch
Comment 2 Rob Buis 2013-03-21 14:46:00 PDT
Comment on attachment 194326 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-03-21 14:54:40 PDT
Comment on attachment 194326 [details]
Patch

Clearing flags on attachment: 194326

Committed r146526: <http://trac.webkit.org/changeset/146526>
Comment 4 WebKit Review Bot 2013-03-21 14:54:43 PDT
All reviewed patches have been landed.  Closing bug.