Bug 112934 - [Windows, WinCairo] Correct Empty BitmapImage Test
Summary: [Windows, WinCairo] Correct Empty BitmapImage Test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 11:09 PDT by Brent Fulgham
Modified: 2013-03-21 17:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2013-03-21 11:30 PDT, Brent Fulgham 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-03-21 11:09:54 PDT 
The TestWebKitAPI test for an empty image frame (added in Bug 102689) incorrectly handles the reference counting aspects of the underlying BitmapImage object.

This patch corrects a debug-build assertion that would trigger for the WinCairo port when running this test.
Comment 1 Brent Fulgham 2013-03-21 11:27:27 PDT 
Note that even with this patch we cannot run this test under the Windows CG build because the implementation of ImageSourceCG asserts that its internal frameCount method is non-zero.  Since we do not provide an underlying CG image source for this test, the assertion will always fire.
Comment 2 Brent Fulgham 2013-03-21 11:30:29 PDT 
Created attachment 194303 [details]
Patch
Comment 3 Brent Fulgham 2013-03-21 17:08:49 PDT 
Landed in r146507.