Bug 112927 - [Skia] Integration of the Skia displacement mapping into WebKit
Summary: [Skia] Integration of the Skia displacement mapping into WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: sugoi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 10:12 PDT by sugoi
Modified: 2013-03-25 09:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.23 KB, patch)
2013-03-22 12:00 PDT, sugoi 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 (539.46 KB, application/zip)
2013-03-22 13:02 PDT, Build Bot 		no flags Details
Archive of layout-test-results from gce-cr-linux-05 (734.39 KB, application/zip)
2013-03-22 13:05 PDT, WebKit Review Bot 		no flags Details
Archive of layout-test-results from webkit-ews-10 (475.24 KB, application/zip)
2013-03-22 14:05 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-03 for mac-future (971.48 KB, application/zip)
2013-03-23 04:36 PDT, Build Bot 		no flags Details
Patch (100.55 KB, patch)
2013-03-25 08:02 PDT, sugoi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description sugoi 2013-03-21 10:12:15 PDT 
Integration of the Skia displacement mapping into WebKit
Comment 1 sugoi 2013-03-22 12:00:12 PDT 
Created attachment 194611 [details]
Patch
Comment 2 Build Bot 2013-03-22 13:02:09 PDT 
Comment on attachment 194611 [details]
Patch

Attachment 194611 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17218638

New failing tests:
css3/filters/effect-reference-hw.html
css3/filters/effect-reference.html
Comment 3 Build Bot 2013-03-22 13:02:10 PDT 
Created attachment 194621 [details]
Archive of layout-test-results from webkit-ews-16

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: <class 'webkitpy.common.config.ports.MacWK2Port'>  Platform: Mac OS X 10.8.2
Comment 4 WebKit Review Bot 2013-03-22 13:05:20 PDT 
Comment on attachment 194611 [details]
Patch

Attachment 194611 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17120792

New failing tests:
css3/filters/effect-reference-hw.html
css3/filters/effect-reference.html
Comment 5 WebKit Review Bot 2013-03-22 13:05:24 PDT 
Created attachment 194622 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 6 Stephen White 2013-03-22 13:51:12 PDT 
Comment on attachment 194611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194611&action=review

You'll need to add some results for at least one platform. It looks like the auto-attaching-failed-results thing is fixed, so I think both the Chromium and Mac (Safari) results are now available. You should be able to download those and integrate them into your patch.

> Source/WebCore/platform/graphics/filters/skia/FEDisplacementMapSkia.cpp:38
> +SkDisplacementMapEffect::ChannelSelectorType toSkiaMode(ChannelSelectorType type)

Nit:  this should be static, or in the unnamed namespace.
Comment 7 Build Bot 2013-03-22 14:05:19 PDT 
Comment on attachment 194611 [details]
Patch

Attachment 194611 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17178771

New failing tests:
css3/filters/effect-reference-hw.html
css3/filters/effect-reference.html
Comment 8 Build Bot 2013-03-22 14:05:22 PDT 
Created attachment 194628 [details]
Archive of layout-test-results from webkit-ews-10

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: <class 'webkitpy.common.config.ports.MacWK2Port'>  Platform: Mac OS X 10.8.2
Comment 9 Build Bot 2013-03-23 04:36:42 PDT 
Comment on attachment 194611 [details]
Patch

Attachment 194611 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17289184

New failing tests:
css3/filters/effect-reference-hw.html
css3/filters/effect-reference.html
Comment 10 Build Bot 2013-03-23 04:36:46 PDT 
Created attachment 194699 [details]
Archive of layout-test-results from webkit-ews-03 for mac-future

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-future  Platform: Mac OS X 10.8.2
Comment 11 sugoi 2013-03-25 08:02:56 PDT 
Created attachment 194859 [details]
Patch
Comment 12 Stephen White 2013-03-25 08:31:53 PDT 
Comment on attachment 194859 [details]
Patch

Looks good, bots willing.  r=me
Comment 13 WebKit Review Bot 2013-03-25 09:12:55 PDT 
Comment on attachment 194859 [details]
Patch

Clearing flags on attachment: 194859

Committed r146779: <http://trac.webkit.org/changeset/146779>
Comment 14 WebKit Review Bot 2013-03-25 09:13:00 PDT 
All reviewed patches have been landed.  Closing bug.