Bug 112916 - Clean up the speech recognintion API
Summary: Clean up the speech recognintion API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords: WebExposed
Depends on:
Blocks: 80261
  Show dependency treegraph
 
Reported: 2013-03-21 08:01 PDT by Tommy Widenflycht
Modified: 2013-03-22 06:45 PDT (History)
8 users (show)

See Also:


Attachments
Patch (16.28 KB, patch)
2013-03-21 08:10 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (19.42 KB, patch)
2013-03-21 09:04 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2013-03-21 08:01:00 PDT
Clean up the speach recognintion API
Comment 1 Tommy Widenflycht 2013-03-21 08:10:04 PDT
Created attachment 194263 [details]
Patch
Comment 2 Tommy Widenflycht 2013-03-21 08:11:45 PDT
This patch cleans away deprecated parts, fixes so that stop() can be called more than once and adds the missing emma attribute on SpeechRecognitionEvent (which is always null).
Comment 3 WebKit Review Bot 2013-03-21 08:11:47 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Tommy Widenflycht 2013-03-21 09:04:33 PDT
Created attachment 194276 [details]
Patch
Comment 5 Adam Barth 2013-03-21 13:23:41 PDT
Comment on attachment 194276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194276&action=review

> Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl:33
> +    readonly attribute Document emma;

Why add this attribute if it's always null?  Perhaps we should wait to add it until it's non-null.
Comment 6 Tommy Widenflycht 2013-03-22 01:27:47 PDT
Comment on attachment 194276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194276&action=review

>> Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl:33
>> +    readonly attribute Document emma;
> 
> Why add this attribute if it's always null?  Perhaps we should wait to add it until it's non-null.

The standard stipulates that if the emma functionality isn't supported this accessor should return null.
Comment 7 WebKit Review Bot 2013-03-22 06:45:34 PDT
Comment on attachment 194276 [details]
Patch

Clearing flags on attachment: 194276

Committed r146601: <http://trac.webkit.org/changeset/146601>
Comment 8 WebKit Review Bot 2013-03-22 06:45:38 PDT
All reviewed patches have been landed.  Closing bug.