RESOLVED FIXED Bug 112916
Clean up the speech recognintion API 
https://bugs.webkit.org/show_bug.cgi?id=112916
Summary Clean up the speech recognintion API
Tommy Widenflycht
Reported 2013-03-21 08:01:00 PDT
Clean up the speach recognintion API
Attachments
Patch (16.28 KB, patch)
2013-03-21 08:10 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (19.42 KB, patch)
2013-03-21 09:04 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2013-03-21 08:10:04 PDT
Created attachment 194263 [details] Patch
Tommy Widenflycht
Comment 2 2013-03-21 08:11:45 PDT
This patch cleans away deprecated parts, fixes so that stop() can be called more than once and adds the missing emma attribute on SpeechRecognitionEvent (which is always null).
WebKit Review Bot
Comment 3 2013-03-21 08:11:47 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Tommy Widenflycht
Comment 4 2013-03-21 09:04:33 PDT
Created attachment 194276 [details] Patch
Adam Barth
Comment 5 2013-03-21 13:23:41 PDT
Comment on attachment 194276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194276&action=review > Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl:33 > + readonly attribute Document emma; Why add this attribute if it's always null? Perhaps we should wait to add it until it's non-null.
Tommy Widenflycht
Comment 6 2013-03-22 01:27:47 PDT
Comment on attachment 194276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194276&action=review >> Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl:33 >> + readonly attribute Document emma; > > Why add this attribute if it's always null? Perhaps we should wait to add it until it's non-null. The standard stipulates that if the emma functionality isn't supported this accessor should return null.
WebKit Review Bot
Comment 7 2013-03-22 06:45:34 PDT
Comment on attachment 194276 [details] Patch Clearing flags on attachment: 194276 Committed r146601: <http://trac.webkit.org/changeset/146601>
WebKit Review Bot
Comment 8 2013-03-22 06:45:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.