RESOLVED INVALID 112912
[Qt][WK2] Remove QtWebError references to internal classes 
https://bugs.webkit.org/show_bug.cgi?id=112912
Summary [Qt][WK2] Remove QtWebError references to internal classes
Jocelyn Turcotte
Reported 2013-03-21 07:08:22 PDT
[Qt][WK2] Remove QtWebError references to internal classes
Attachments
Patch (2.54 KB, patch)
2013-03-21 07:10 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2013-03-21 07:10:22 PDT
Created attachment 194256 [details] Patch
Jocelyn Turcotte
Comment 2 2013-03-21 07:13:09 PDT
Comment on attachment 194256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194256&action=review > Source/WebKit2/UIProcess/qt/QtWebError.cpp:70 > + // This must match with WebKit::cancelledError(const WebCore::ResourceRequest&) > + return type() == NetworkError && errorCode() == QNetworkReply::OperationCanceledError; Another way would be to expose isCancellation in the C API, but I chose this way as this would duplicate the information provided by the error code. A standard cancellation error domain/code would also be nice, but without knowing how it is currently used I'm afraid this would break other ports if they already rely on their internal code.
Jocelyn Turcotte
Comment 3 2014-02-03 03:25:25 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.