Nit: Don't rely on implicit conversion from KURL to String in XSSAuditorDelegate::didBlockScript.
Created attachment 194240 [details] Patch
Created attachment 195534 [details] Patch
(In reply to comment #2) > Created an attachment (id=195534) [details] > Patch I thought blankURL() was "about:blank"
(In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=195534) [details] [details] > > Patch > > I thought blankURL() was "about:blank" 'blankURL()' wraps 'about:blank' in a static KURL: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/KURL.cpp#L1746. *shrug* not a big deal, just a little nitpicky thing I want to fix. :) Actually... It would probably be worthwhile to have KURL static constants for things like 'about:blank' and 'data:<p></p>' if we're using them as strings in multiple places.
Comment on attachment 195534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195534&action=review I think this is probably okay, but I'd like clarification before we commit this. > Source/WebCore/ChangeLog:16 > + pass in 'String()' explicitly. We can also drop the String() cast Is this really the same thing? Wouldn't the String produced by blankURL be a string containing the "about:blank" characters? Does scheduleLocationChange treat this identically to a blank string? > Source/WebCore/html/parser/XSSAuditorDelegate.cpp:114 > + m_document->frame()->navigationScheduler()->scheduleLocationChange(m_document->securityOrigin(), "data:text/html,<p></p>", String()); So you are saying that String() in this context will behave the same as the "about:blank" behavior of blankURL()?
The XSSAuditor is removed in Bug 230499.