Bug 112897 – When table cell have inline children which change writing-mode, the cell overflows its contents.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Yuki Sekiguchi]

Created attachment 194220 [details]
reproduced html content

In the attached content, span element in the 1st table is overflowed.
Table should not overflow its content in normal case.

Table likely use contents width not height to calculate its cell width.

[Yuki Sekiguchi]

Created attachment 194222 [details]
Patch

[WebKit Review Bot]

Comment on attachment 194222 [details]
Patch

Attachment 194222 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17200565

New failing tests:
fast/table/colspanMinWidth-vertical.html

[WebKit Review Bot]

Created attachment 194251 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Andreas Kling]

Comment on attachment 194222 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.

[Yuki Sekiguchi]

Created attachment 223303 [details]
Patch

[Build Bot]

Comment on attachment 223303 [details]
Patch

Attachment 223303 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6415375268839424

New failing tests:
fast/table/colspanMinWidth-vertical.html

[Build Bot]

Created attachment 223307 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 223303 [details]
Patch

Attachment 223303 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5232251365228544

New failing tests:
fast/table/colspanMinWidth-vertical.html

[Build Bot]

Created attachment 223308 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Yuki Sekiguchi]

Created attachment 223312 [details]
Patch

[Yuki Sekiguchi]

I landed the same patch to Blink at http://src.chromium.org/viewvc/blink?view=revision&revision=163239

[Yuki Sekiguchi]

Created attachment 223319 [details]
Patch

[Michael Catanzaro]

Comment on attachment 223319 [details]
Patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.

[EWS]

Committed 255919@main (29a59ed73e09): <https://commits.webkit.org/255919@main>

Reviewed commits have been landed. Closing PR #5679 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/101504664>