Bug 112892 - WinCairo build fails to link.
Summary: WinCairo build fails to link.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 02:55 PDT by peavo
Modified: 2013-03-22 09:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2013-03-21 03:00 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-03-21 02:55:02 PDT
The VS2005 WinCairo build fails with the following linker error:

WebKit.exp : error LNK2001: unresolved external symbol "public: class WebCore::CaptionUserPreferences * __thiscall WebCore::PageGroup::captionPreferences(void)" (?captionPreferences@PageGroup@WebCore@@QAEPAVCaptionUserPreferences@2@XZ)
C:\webkitdist\Release_Cairo_CFLite\bin\WebKit.dll : fatal error LNK1120: 1 unresolved externals
Comment 1 peavo 2013-03-21 03:00:29 PDT
Created attachment 194211 [details]
Patch
Comment 2 Kentaro Hara 2013-03-21 17:57:00 PDT
Comment on attachment 194211 [details]
Patch

rs=me
Comment 3 WebKit Review Bot 2013-03-21 18:34:53 PDT
Comment on attachment 194211 [details]
Patch

Clearing flags on attachment: 194211

Committed r146550: <http://trac.webkit.org/changeset/146550>
Comment 4 WebKit Review Bot 2013-03-21 18:34:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2013-03-22 09:21:26 PDT
Thanks for fixing this.  I corrected it in the VS2010 build, but forgot to check the VS2005 side!