Bug 112883 - [meta][Chromium] Implement page cache support
Summary: [meta][Chromium] Implement page cache support
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://code.google.com/p/chromium/is...
Keywords:
Depends on: 112884 112885 112887
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-21 00:36 PDT by Chris Dumez
Modified: 2013-04-08 16:56 PDT (History)
6 users (show)

See Also:


Attachments
Full WIP patch for reference (17.20 KB, patch)
2013-03-21 00:47 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Full WIP patch for reference (20.37 KB, patch)
2013-03-21 03:42 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Full WIP patch for reference (17.37 KB, patch)
2013-03-21 08:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-03-21 00:36:04 PDT
The chromium port does not currently enable page cache support. With the default process model in Chromium (Process per site instance), the page cache may not work as expected because a new process may be created when navigating to a new site instance. However, page cache would work correctly with minor modifications for other process models (process per tab or single process).

Given that chromium supports different process models and that page cache would be beneficial for at least some of them. I propose to implement page cache support in chromium port.
Comment 1 Chris Dumez 2013-03-21 00:47:13 PDT
Created attachment 194197 [details]
Full WIP patch for reference

Posting a full WIP patch here for reference. The idea is to split it and get review in separate sub-bugs though.
Comment 2 Chris Dumez 2013-03-21 01:21:40 PDT
Useful manual test case:
http://www.twmagic.com/misc/cache-nocache.html
Comment 3 Chris Dumez 2013-03-21 03:42:19 PDT
Created attachment 194216 [details]
Full WIP patch for reference
Comment 4 Chris Dumez 2013-03-21 08:38:28 PDT
Created attachment 194270 [details]
Full WIP patch for reference

Revert WebHistoryItem changes as this should probably be solved on Chromium side, not WebKit side.
Comment 5 Adam Barth 2013-03-21 09:52:55 PDT
It's not clear to me that we want to support the PageCache in Chromium.  We should discuss that first before landing these patches.
Comment 6 Laszlo Gombos 2013-03-21 17:08:00 PDT
(In reply to comment #5)
> It's not clear to me that we want to support the PageCache in Chromium.  We should discuss that first before landing these patches.

Adam, can you help the discussion by listing your concerns ? The combination of the existing --enable-fastback chromium command line options, the open chromium bug with a few dups and some related patches landed (e.g. r110998) let us believe that page cache for chromium would be a value at least conditionally (in case it is not enabled by default).
Comment 7 Adam Barth 2013-03-21 17:39:26 PDT
I'm about to go on vacation.  Perhaps we should discuss the topic on chromium-dev when I get back? My main concerns are memory usage, complexity, and the interaction with the multiprocess architecture.
Comment 8 Stephen Chenney 2013-04-08 16:56:48 PDT
Shift all discussion to the Chromium bug.