Bug 112845 – "" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 194127 [details]
the patch

[WebKit Review Bot]

Attachment 194127 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/empty-string-plus-int-expected.txt', u'LayoutTests/fast/js/regress/empty-string-plus-int.html', u'LayoutTests/fast/js/regress/script-tests/empty-string-plus-int.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.h']" exit_code: 1
Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.h:51:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Hahnenberg]

Comment on attachment 194127 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194127&action=review

r=me

> Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:46
> +    if (isObjectSpeculation(type)) {
> +        // I'd love to fold this case into the case below, but I can't, because
> +        // removing SpecObject from something that only has an object
> +        // prediction and nothing else means we have an ill-formed SpeculatedType
> +        // (strong predict-none). This should be killed once we remove all traces
> +        // of static (aka weak) predictions.
> +        return type;
> +    }

According to this comment, we can now delete this branch.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/146400

[Filip Pizlo]

Test landed in http://trac.webkit.org/changeset/146400