Bug 112842 - AX: when no other label on provided on form elements, WebKit should fall back to using @title
Summary: AX: when no other label on provided on form elements, WebKit should fall back...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 119695 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-03-20 13:59 PDT by James Craig
Modified: 2013-09-25 17:45 PDT (History)
13 users (show)

See Also:


Attachments
test case demonstrating bug (633 bytes, text/html)
2013-03-20 13:59 PDT, James Craig
no flags Details
Patch. (4.17 KB, patch)
2013-09-03 14:39 PDT, Samuel White
no flags Details | Formatted Diff | Diff
Patch. (4.15 KB, patch)
2013-09-03 14:46 PDT, Samuel White
cfleizach: review-
Details | Formatted Diff | Diff
Patch. (4.11 KB, patch)
2013-09-04 10:26 PDT, Samuel White
cfleizach: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (508.08 KB, application/zip)
2013-09-04 11:53 PDT, Build Bot
no flags Details
Patch. (4.09 KB, patch)
2013-09-04 14:23 PDT, Samuel White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2013-03-20 13:59:02 PDT
AX: when no other label on provided on form elements, WebKit should fall back to using @title 

Load attached test case. @title is exposed as AXHelp here. It should be exposed as the label, and only fall back to helptext if there is another label provided according to the ARIA name calculation steps:

http://www.w3.org/WAI/PF/aria/complete#namecalculation
Comment 1 James Craig 2013-03-20 13:59:36 PDT
Created attachment 194114 [details]
test case demonstrating bug
Comment 2 Radar WebKit Bug Importer 2013-03-20 15:37:06 PDT
<rdar://problem/13467139>
Comment 3 James Craig 2013-04-14 23:28:19 PDT
related to bug 114535
Comment 4 James Craig 2013-09-03 14:18:36 PDT
Filed as a spec bug on ARIA 1.1 to more explicitly disallow null, empty, or whitespace-only strings as "valid" label value.

PFWG-ISSUE-609 (empty string labels are technically valid): Text Alt Comp section does not explicitly disallow empty strings as a valid label [ARIA 1.1]

https://www.w3.org/WAI/PF/Group/track/issues/609
Comment 5 Samuel White 2013-09-03 14:39:19 PDT
Created attachment 210411 [details]
Patch.

Patch stops empty labels from being used when we're computing accessibility text.
Comment 6 WebKit Commit Bot 2013-09-03 14:41:38 PDT
Attachment 210411 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/accessibility/input-title-expected.txt', u'LayoutTests/platform/mac/accessibility/input-title.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp']" exit_code: 1
Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1175:  Extra space after ( in if  [whitespace/parens] [5]
Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1175:  Extra space before ) in if  [whitespace/parens] [5]
Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1177:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Samuel White 2013-09-03 14:46:47 PDT
Created attachment 210413 [details]
Patch.

Fixed style issue.
Comment 8 chris fleizach 2013-09-03 23:09:56 PDT
Comment on attachment 210413 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=210413&action=review

patch looks good otherwise.

> LayoutTests/ChangeLog:1
> +2013-09-03  Samuel White  <samuel_white@da0602a-dhcp103.apple.com>

ditto about email address

> Source/WebCore/ChangeLog:1
> +2013-09-03  Samuel White  <samuel_white@da0602a-dhcp103.apple.com>

you need to fix your email address here. I believe you can set this in your bash profile

> Source/WebCore/ChangeLog:8
> +        Don't let input elements include empty labels in their

no need for two lines here.
Comment 9 Mario Sanchez Prada 2013-09-04 02:58:00 PDT
(In reply to comment #8)
> [...]
> > Source/WebCore/ChangeLog:1
> > +2013-09-03  Samuel White  <samuel_white@da0602a-dhcp103.apple.com>
> 
> you need to fix your email address here. I believe you can set this in your bash profile

JFTR, in my case I do that by having the following in my ~/.bashrc file of my Linux box:

 export EMAIL_ADDRESS=mario.prada@samsung.com
Comment 10 Samuel White 2013-09-04 10:26:55 PDT
Created attachment 210474 [details]
Patch.

Doh! Thanks for catching the email issue. Forgot to config git on this computer.
Comment 11 Build Bot 2013-09-04 11:53:47 PDT
Comment on attachment 210474 [details]
Patch.

Attachment 210474 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1692646

New failing tests:
platform/mac/accessibility/input-title.html
Comment 12 Build Bot 2013-09-04 11:53:49 PDT
Created attachment 210483 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 13 Samuel White 2013-09-04 13:08:15 PDT
Hmm. Not sure why this test was passing yesterday and failed today with zero changes. Is this a possible false positive? Did something major land that could have broken this Chris?
Comment 14 chris fleizach 2013-09-04 13:23:59 PDT
not sure. i guess we should re-run locally and see if it repros. the fix seems pretty safe
Comment 15 Samuel White 2013-09-04 13:25:17 PDT
(In reply to comment #14)
> not sure. i guess we should re-run locally and see if it repros. the fix seems pretty safe

At first glance it looks like http://trac.webkit.org/changeset/155022 may be causing these input elements to expose their title via help text.
Comment 16 Samuel White 2013-09-04 14:23:20 PDT
Created attachment 210497 [details]
Patch.

As suspected, http://trac.webkit.org/changeset/155022 changed how we compute AXTitle and AXDescription. Attached is an updated patch that accounts for these changes. Thanks.
Comment 17 WebKit Commit Bot 2013-09-04 15:54:53 PDT
Comment on attachment 210497 [details]
Patch.

Clearing flags on attachment: 210497

Committed r155078: <http://trac.webkit.org/changeset/155078>
Comment 18 WebKit Commit Bot 2013-09-04 15:54:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 19 Samuel White 2013-09-25 17:45:13 PDT
*** Bug 119695 has been marked as a duplicate of this bug. ***