Bug 112833 - REGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are being copied into the wrong location
Summary: REGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-20 13:35 PDT by Jessie Berlin
Modified: 2013-08-01 14:40 PDT (History)
7 users (show)

See Also:


Attachments
Patch (9.31 KB, patch)
2013-03-20 13:44 PDT, Jessie Berlin
no flags Details | Formatted Diff | Diff
Patch (3.08 KB, patch)
2013-08-01 14:35 PDT, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2013-03-20 13:35:25 PDT
They are ending up in MyBuildDir/Debug/usr/local/include instead of MyBuildDir/Debug/usr/local/include/wtf

They need to be copied with the rest of the headers in the Project section of the Copy Public Headers step.

The were incorrectly marked as private in http://trac.webkit.org/changeset/145592

<rdar://problem/13463134>
Comment 1 Jessie Berlin 2013-03-20 13:44:56 PDT
Created attachment 194109 [details]
Patch
Comment 2 Jessie Berlin 2013-03-20 15:05:30 PDT
Comment on attachment 194109 [details]
Patch

Committed in http://trac.webkit.org/changeset/146394
Comment 3 Simon Fraser (smfr) 2013-08-01 14:26:32 PDT
This seems to have broken again.
Comment 4 Simon Fraser (smfr) 2013-08-01 14:35:10 PDT
Created attachment 207952 [details]
Patch
Comment 5 Sam Weinig 2013-08-01 14:37:36 PDT
Comment on attachment 207952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207952&action=review

> Source/WTF/ChangeLog:9
> +        privaet headers, so they get copied into <build dir>/usr/local/include/wtf

Typo - private.
Comment 6 Simon Fraser (smfr) 2013-08-01 14:40:28 PDT
http://trac.webkit.org/changeset/153609