Currently, LightSource implements a series of methods whose sole purpose is dispatching to sub-classes based on a type field. By using virtual dispatchers, we could: * eliminate all the static casts * remove LightSource.cpp altogether
Created attachment 194096 [details] Patch
Comment on attachment 194096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194096&action=review Good find. Security will be happy. > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:13644 > +</Project> We probably shouldn't reorder these lines.
Thanks Stephen. (In reply to comment #2) > > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:13644 > > +</Project> > > We probably shouldn't reorder these lines. I think that's just git diff getting confused - there's no "\ No newline at end of file" line in that file...
Comment on attachment 194096 [details] Patch Clearing flags on attachment: 194096 Committed r146503: <http://trac.webkit.org/changeset/146503>
All reviewed patches have been landed. Closing bug.