Bug 112827 - [SVG] Remove explicit LightSource dispatchers
Summary: [SVG] Remove explicit LightSource dispatchers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Florin Malita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-20 12:30 PDT by Florin Malita
Modified: 2013-03-21 13:05 PDT (History)
8 users (show)

See Also:


Attachments
Patch (18.56 KB, patch)
2013-03-20 12:37 PDT, Florin Malita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florin Malita 2013-03-20 12:30:10 PDT
Currently, LightSource implements a series of methods whose sole purpose is dispatching to sub-classes based on a type field.

By using virtual dispatchers, we could:

* eliminate all the static casts
* remove LightSource.cpp altogether
Comment 1 Florin Malita 2013-03-20 12:37:31 PDT
Created attachment 194096 [details]
Patch
Comment 2 Stephen Chenney 2013-03-21 12:26:34 PDT
Comment on attachment 194096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194096&action=review

Good find. Security will be happy.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:13644
> +</Project>

We probably shouldn't reorder these lines.
Comment 3 Florin Malita 2013-03-21 12:53:26 PDT
Thanks Stephen.

(In reply to comment #2)
> > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:13644
> > +</Project>
> 
> We probably shouldn't reorder these lines.

I think that's just git diff getting confused - there's no "\ No newline at end of file" line in that file...
Comment 4 WebKit Review Bot 2013-03-21 13:05:07 PDT
Comment on attachment 194096 [details]
Patch

Clearing flags on attachment: 194096

Committed r146503: <http://trac.webkit.org/changeset/146503>
Comment 5 WebKit Review Bot 2013-03-21 13:05:12 PDT
All reviewed patches have been landed.  Closing bug.