RESOLVED WONTFIX 112825
[Chromium] Move openFileSystem and deleteFileSystem to Platform.h 
https://bugs.webkit.org/show_bug.cgi?id=112825
Summary [Chromium] Move openFileSystem and deleteFileSystem to Platform.h
Mark Pilgrim (Google)
Reported 2013-03-20 11:17:20 PDT
[Chromium] Move openFileSystem and deleteFileSystem to Platform.h
Attachments
Patch (9.46 KB, patch)
2013-03-20 11:19 PDT, Mark Pilgrim (Google) 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2013-03-20 11:19:18 PDT
Created attachment 194091 [details] Patch
Mark Pilgrim (Google)
Comment 2 2013-03-20 11:20:03 PDT
Comment on attachment 194091 [details] Patch Needs changes in Chromium to land first (adding the actual implementation).
WebKit Review Bot
Comment 3 2013-03-20 11:22:10 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 4 2013-03-20 11:22:25 PDT
Comment on attachment 194091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194091&action=review > Source/Platform/chromium/public/Platform.h:182 > + virtual void openFileSystem( > + WebString, WebFileSystemType, long long size, > + bool create, WebFileSystemCallbacks*) { } We can put this all on one line. Is there a reason to put this on Platform directly instead of on WebFileSystem? > Source/Platform/chromium/public/Platform.h:191 > + virtual void deleteFileSystem( > + WebString, WebFileSystemType, WebFileSystemCallbacks*) { } ditto
Adam Barth
Comment 5 2013-03-20 11:26:43 PDT
Comment on attachment 194091 [details] Patch (modulo question above)
WebKit Review Bot
Comment 6 2013-03-20 12:51:43 PDT
Comment on attachment 194091 [details] Patch Attachment 194091 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17129728 New failing tests: http/tests/security/filesystem-iframe-from-remote.html fast/filesystem/workers/file-writer-sync-truncate-extend.html http/tests/filesystem/workers/resolve-url.html http/tests/cache/subresource-failover-to-network.html fast/css/font-family-pictograph.html http/tests/inspector/filesystem/delete-entry.html fast/filesystem/file-from-file-entry.html fast/filesystem/workers/file-writer-gc-blob.html fast/filesystem/directory-entry-to-uri.html http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html http/tests/filesystem/workers/resolve-url-sync.html fast/filesystem/workers/file-from-file-entry-sync.html fast/filesystem/file-writer-abort-continue.html http/tests/filesystem/no-cache-filesystem-url.html fast/filesystem/workers/file-writer-empty-blob.html fast/filesystem/async-operations.html http/tests/inspector/filesystem/request-file-content.html fast/filesystem/file-entry-to-uri.html http/tests/inspector/filesystem/request-metadata.html fast/filesystem/workers/file-writer-events.html http/tests/inspector/filesystem/request-directory-content.html fast/filesystem/file-metadata-after-write.html http/tests/filesystem/resolve-uri.html http/tests/inspector/filesystem/directory-tree.html fast/filesystem/file-after-reload-crash.html fast/filesystem/workers/file-entry-to-uri-sync.html fast/dom/MutationObserver/filesystem-callback-delivery.html fast/filesystem/workers/file-from-file-entry.html http/tests/inspector/filesystem/request-filesystem-root.html fast/filesystem/cross-filesystem-op.html
Note You need to log in before you can comment on or make changes to this bug.