Bug 112819 - Add webp to supported image mime types if WEBP feature is enabled/used
Summary: Add webp to supported image mime types if WEBP feature is enabled/used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeff Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-20 09:17 PDT by Jeff Rogers
Modified: 2013-04-09 09:51 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2013-03-20 09:28 PDT, Jeff Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Rogers 2013-03-20 09:17:04 PDT 
Currently enabling WebP image support will not allow ImageDocument to display .webp images as Image.supportsType will return false.
Add "image/webp" in MIMETypeRegistry::initializeSupportedImageMIMETypes if USE(WEBP).
Comment 1 Jeff Rogers 2013-03-20 09:28:58 PDT 
Created attachment 194078 [details]
Patch
Comment 2 Darin Adler 2013-04-09 09:26:59 PDT 
Comment on attachment 194078 [details]
Patch

OK
Comment 3 Darin Adler 2013-04-09 09:27:27 PDT 
Comment on attachment 194078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194078&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests: WebP image decoding already covered by exisiting tests.

I don’t understand this logic. Obviously adding the supported MIME type has some effect on behavior, so there must be something testable.
Comment 4 WebKit Commit Bot 2013-04-09 09:51:05 PDT 
Comment on attachment 194078 [details]
Patch

Clearing flags on attachment: 194078

Committed r148028: <http://trac.webkit.org/changeset/148028>
Comment 5 WebKit Commit Bot 2013-04-09 09:51:06 PDT 
All reviewed patches have been landed.  Closing bug.