Bug 112809 - [V8] Web Inspector: use isolate-based versions of CPU and Heap profilers
Summary: [V8] Web Inspector: use isolate-based versions of CPU and Heap profilers
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-20 07:19 PDT by Yury Semikhatsky
Modified: 2013-04-05 13:01 PDT (History)
14 users (show)

See Also:

Attachments
Patch (6.53 KB, patch)
2013-03-20 07:22 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (6.87 KB, patch)
2013-03-20 08:03 PDT, Yury Semikhatsky 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-03-20 07:19:52 PDT 
Static V8 profiler API is being deprecated in favor of isolate based one. This change migrates WebCore to the new API.
Comment 1 Yury Semikhatsky 2013-03-20 07:22:29 PDT 
Created attachment 194049 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-20 07:29:07 PDT 
Comment on attachment 194049 [details]
Patch

Attachment 194049 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17121831
Comment 3 WebKit Review Bot 2013-03-20 07:29:55 PDT 
Comment on attachment 194049 [details]
Patch

Attachment 194049 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17122782
Comment 4 Peter Beverloo (cr-android ews) 2013-03-20 07:35:43 PDT 
Comment on attachment 194049 [details]
Patch

Attachment 194049 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17242139
Comment 5 Yury Semikhatsky 2013-03-20 07:56:02 PDT 
(In reply to comment #0)
> Static V8 profiler API is being deprecated in favor of isolate based one. This change migrates WebCore to the new API.

The patch depends on V8 changes that are not rolled yet:
https://code.google.com/p/v8/source/detail?r=14006
https://code.google.com/p/v8/source/detail?r=13997
Comment 6 Ilya Tikhonovsky 2013-03-20 08:02:10 PDT 
Comment on attachment 194049 [details]
Patch

lgtm with nits: please fix names for handleScope variables.
Comment 7 Yury Semikhatsky 2013-03-20 08:03:53 PDT 
Created attachment 194059 [details]
Patch
Comment 8 Yury Semikhatsky 2013-03-20 08:07:26 PDT 
(In reply to comment #6)
> (From update of attachment 194049 [details])
> lgtm with nits: please fix names for handleScope variables.

Done.
Comment 9 WebKit Review Bot 2013-03-20 08:08:49 PDT 
Comment on attachment 194059 [details]
Patch

Attachment 194059 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17121855
Comment 10 WebKit Review Bot 2013-03-20 08:09:18 PDT 
Comment on attachment 194059 [details]
Patch

Attachment 194059 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17286019
Comment 11 Peter Beverloo (cr-android ews) 2013-03-20 08:12:33 PDT 
Comment on attachment 194059 [details]
Patch

Attachment 194059 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17242167
Comment 12 Timothy Hatcher 2013-04-05 13:01:54 PDT 
Chromium and V8 have left the building. Won't fix.