RESOLVED FIXED 112808
[Qt] Define MODULE_VERSION 
https://bugs.webkit.org/show_bug.cgi?id=112808
Summary [Qt] Define MODULE_VERSION
Jocelyn Turcotte
Reported 2013-03-20 07:00:00 PDT
[Qt] Define MODULE_VERSION
Attachments
Patch (1.03 KB, patch)
2013-03-20 07:02 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2013-03-20 07:02:35 PDT
Created attachment 194047 [details] Patch
Jocelyn Turcotte
Comment 2 2013-03-20 08:01:47 PDT
Humm I can't push that yet, the headers are sometimes using the qtbase module version for private headers and sometimes the qtwebkit one. So we need to MODULE_VERSION to be defined the same as qtbase until this is fixed.
Jocelyn Turcotte
Comment 3 2013-03-20 10:50:12 PDT
Comment on attachment 194047 [details] Patch This depends on https://codereview.qt-project.org/51591 but I'll commit it now since it won't break anything more than it is now.
WebKit Review Bot
Comment 4 2013-03-20 10:58:34 PDT
Comment on attachment 194047 [details] Patch Clearing flags on attachment: 194047 Committed r146363: <http://trac.webkit.org/changeset/146363>
WebKit Review Bot
Comment 5 2013-03-20 10:58:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.