Bug 112808 - [Qt] Define MODULE_VERSION
Summary: [Qt] Define MODULE_VERSION
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-20 07:00 PDT by Jocelyn Turcotte
Modified: 2013-03-20 10:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.03 KB, patch)
2013-03-20 07:02 PDT, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2013-03-20 07:00:00 PDT 
[Qt] Define MODULE_VERSION
Comment 1 Jocelyn Turcotte 2013-03-20 07:02:35 PDT 
Created attachment 194047 [details]
Patch
Comment 2 Jocelyn Turcotte 2013-03-20 08:01:47 PDT 
Humm I can't push that yet, the headers are sometimes using the qtbase module version for private headers and sometimes the qtwebkit one.

So we need to MODULE_VERSION to be defined the same as qtbase until this is fixed.
Comment 3 Jocelyn Turcotte 2013-03-20 10:50:12 PDT 
Comment on attachment 194047 [details]
Patch

This depends on https://codereview.qt-project.org/51591 but I'll commit it now since it won't break anything more than it is now.
Comment 4 WebKit Review Bot 2013-03-20 10:58:34 PDT 
Comment on attachment 194047 [details]
Patch

Clearing flags on attachment: 194047

Committed r146363: <http://trac.webkit.org/changeset/146363>
Comment 5 WebKit Review Bot 2013-03-20 10:58:37 PDT 
All reviewed patches have been landed.  Closing bug.