Bug 112794 - [EFL][WK2] Do not allow passing null pointers for *Ref types
Summary: [EFL][WK2] Do not allow passing null pointers for *Ref types
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
: 109276 (view as bug list)
Depends on:
Blocks: 107820
  Show dependency tree / graph
 
Reported: 2013-03-20 05:58 PDT by Kenneth Rohde Christiansen
Modified: 2017-03-11 10:37 PST (History)
10 users (show)

See Also:

Attachments
Patch (3.46 KB, patch)
2013-03-20 06:00 PDT, Kenneth Rohde Christiansen 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2013-03-20 05:58:55 PDT 
SSIA
Comment 1 Kenneth Rohde Christiansen 2013-03-20 06:00:33 PDT 
Created attachment 194028 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2013-03-20 06:06:30 PDT 
*** Bug 109276 has been marked as a duplicate of this bug. ***
Comment 3 Mikhail Pozdnyakov 2013-03-20 06:07:05 PDT 
Comment on attachment 194028 [details]
Patch

LGTM
Comment 4 Mikhail Pozdnyakov 2013-03-20 06:07:42 PDT 
Comment on attachment 194028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194028&action=review

> Source/WebKit2/UIProcess/API/C/efl/WKView.h:53
> +WK_EXPORT WKViewRef WKViewCreateWithPageGroup(WKContextRef context, WKPageGroupRef pageGroup);

nit: variable names can be omitted
Comment 5 Chris Dumez 2013-03-20 06:09:07 PDT 
Comment on attachment 194028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194028&action=review

> Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:41
>      RefPtr<WebView> webView = WebView::create(toImpl(contextRef), toImpl(pageGroupRef));

How about null-check assertions for args?
Comment 6 Kenneth Rohde Christiansen 2013-03-20 06:12:35 PDT 
> How about null-check assertions for args?

I don't mind and I can do that if a reviewer thinks that makes sense. The asserts could also be in toImpl/toAPI instead.
Comment 7 Chris Dumez 2013-03-20 06:13:35 PDT 
(In reply to comment #6)
> > How about null-check assertions for args?
> 
> I don't mind and I can do that if a reviewer thinks that makes sense. The asserts could also be in toImpl/toAPI instead.

Right, other C API code does not usually use assertions either. LGTM then.
Comment 8 Kenneth Rohde Christiansen 2013-03-20 06:20:36 PDT 
Ping owner review/sign off.
Comment 9 Chris Dumez 2013-05-16 13:06:26 PDT 
Comment on attachment 194028 [details]
Patch

Entirely port specific so it should no longer require owner review. r=me.
Comment 10 Michael Catanzaro 2017-03-11 10:37:12 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.