Bug 112794 – [EFL][WK2] Do not allow passing null pointers for *Ref types

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Kenneth Rohde Christiansen]

SSIA

[Kenneth Rohde Christiansen]

Created attachment 194028 [details]
Patch

[Kenneth Rohde Christiansen]

*** Bug 109276 has been marked as a duplicate of this bug. ***

[Mikhail Pozdnyakov]

Comment on attachment 194028 [details]
Patch

LGTM

[Mikhail Pozdnyakov]

Comment on attachment 194028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194028&action=review

> Source/WebKit2/UIProcess/API/C/efl/WKView.h:53
> +WK_EXPORT WKViewRef WKViewCreateWithPageGroup(WKContextRef context, WKPageGroupRef pageGroup);

nit: variable names can be omitted

[Chris Dumez]

Comment on attachment 194028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194028&action=review

> Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:41
>      RefPtr<WebView> webView = WebView::create(toImpl(contextRef), toImpl(pageGroupRef));

How about null-check assertions for args?

[Kenneth Rohde Christiansen]

> How about null-check assertions for args?

I don't mind and I can do that if a reviewer thinks that makes sense. The asserts could also be in toImpl/toAPI instead.

[Chris Dumez]

(In reply to comment #6)
> > How about null-check assertions for args?
> 
> I don't mind and I can do that if a reviewer thinks that makes sense. The asserts could also be in toImpl/toAPI instead.

Right, other C API code does not usually use assertions either. LGTM then.

[Kenneth Rohde Christiansen]

Ping owner review/sign off.

[Chris Dumez]

Comment on attachment 194028 [details]
Patch

Entirely port specific so it should no longer require owner review. r=me.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.