checkLayout in check-layout.js automatically selects the logging container based on the source node (the node or its parent). In some cases this is undesirable because it may modify the elements getting measured (if they are nested).
Created attachment 194030 [details] Patch
Comment on attachment 194030 [details] Patch Attachment 194030 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17195388 New failing tests: css3/flexbox/box-sizing.html css3/flexbox/multiline-justify-content.html css3/flexbox/flex-flow-margins.html fast/block/margin-collapse/self-collapsing-block-with-float-children.html http/tests/cache/subresource-failover-to-network.html css3/flexbox/multiline-align-content-horizontal-column.html css3/flexbox/flex-align.html css3/flexbox/preferred-widths-orthogonal.html css3/flexbox/preferred-widths.html css3/flexbox/line-wrapping.html css3/flexbox/flex-align-vertical-writing-mode.html css3/flexbox/intrinsic-min-width-applies-with-fixed-width.html css3/flexbox/flex-item-min-size.html fast/css-grid-layout/auto-content-resolution-columns.html css3/flexbox/flex-flow-margins-auto-size.html css3/flexbox/position-absolute-child.html css3/flexbox/flex-flow-auto-margins.html css3/flexbox/flex-flow-padding.html css3/flexbox/multiline.html css3/flexbox/multiline-align-self.html css3/flexbox/flex-align-end.html css3/flexbox/flex-flow-orientations.html css3/flexbox/position-absolute-children.html css3/flexbox/flex-flow-overflow.html css3/flexbox/flexitem.html css3/flexbox/nested-stretch.html css3/flexbox/flex-flow-auto-margins-no-available-space.html css3/flexbox/true-centering.html css3/flexbox/flex-flow-border.html fast/block/min-max-height-percent-height-child.html
Created attachment 194071 [details] Patch
Created attachment 194080 [details] Test case using a complex checkLayout()
Comment on attachment 194071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194071&action=review > LayoutTests/resources/check-layout.js:187 > + var container = overrideContainer; > + if (!overrideContainer) > + container = node.parentNode.className == 'container' ? node.parentNode : node; This can also be written: var container = overrideContainer || (node.parentNode.className == 'container' ? node.parentNode : node);
Comment on attachment 194071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194071&action=review > LayoutTests/ChangeLog:12 > + (.): Seriously, don’t leave lines like this in ChangeLog unless you want me to cry.
Comment on attachment 194071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194071&action=review >> LayoutTests/ChangeLog:12 >> + (.): > > Seriously, don’t leave lines like this in ChangeLog unless you want me to cry. Hold your tears :). I've started removing them once people told me to do it. The patch is just a bit older than that.
Comment on attachment 194071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194071&action=review >>> LayoutTests/ChangeLog:12 >>> + (.): >> >> Seriously, don’t leave lines like this in ChangeLog unless you want me to cry. > > Hold your tears :). I've started removing them once people told me to do it. The patch is just a bit older than that. Oh, and thanks for the review!
Created attachment 201681 [details] Patch for landing
Created attachment 201682 [details] Patch for landing w/ reviewer
Comment on attachment 201682 [details] Patch for landing w/ reviewer Clearing flags on attachment: 201682 Committed r150067: <http://trac.webkit.org/changeset/150067>
All reviewed patches have been landed. Closing bug.