Bug 112768 - It's called "Hash Consing" not "Hash Consting"
Summary: It's called "Hash Consing" not "Hash Consting"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-19 18:33 PDT by Filip Pizlo
Modified: 2013-03-20 13:46 PDT (History)
8 users (show)

See Also:

Attachments
patch for landing (11.76 KB, patch)
2013-03-19 18:33 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-03-19 18:33:07 PDT 
Patch forthcoming.  Already rubber stamped by Mark Hahnenberg.
Comment 1 Filip Pizlo 2013-03-19 18:33:39 PDT 
Created attachment 193964 [details]
patch for landing

Just want to make sure it won't set fire to the universe.
Comment 2 WebKit Review Bot 2013-03-19 18:35:07 PDT 
Attachment 193964 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/GCThreadSharedData.cpp', u'Source/JavaScriptCore/heap/GCThreadSharedData.h', u'Source/JavaScriptCore/heap/SlotVisitor.cpp', u'Source/JavaScriptCore/heap/SlotVisitor.h', u'Source/JavaScriptCore/runtime/JSGlobalData.cpp', u'Source/JavaScriptCore/runtime/JSGlobalData.h', u'Source/JavaScriptCore/runtime/JSString.h']" exit_code: 1
Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2013-03-20 13:46:11 PDT 
Landed in http://trac.webkit.org/changeset/146382