Bug 112767 - Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
Summary: Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Falkenhagen
URL:
Keywords:
Depends on:
Blocks: 112085
  Show dependency tree / graph
 
Reported: 2013-03-19 18:22 PDT by Matt Falkenhagen
Modified: 2013-03-20 17:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.72 KB, patch)
2013-03-19 18:30 PDT, Matt Falkenhagen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Falkenhagen 2013-03-19 18:22:45 PDT 
The calls were added in http://trac.webkit.org/changeset/86526. disabled() never returns true for these elements, so we don't have to consider disabled() in supportsFocus(), and can just use HTMLElement::supportsFocus. Since HTMLMeterElement and HTMLProgressElement no longer inherit from HTMLFormControlElement, we don't need to override supportsFocus() at all.
Comment 1 Matt Falkenhagen 2013-03-19 18:30:56 PDT 
Created attachment 193963 [details]
Patch
Comment 2 Kent Tamura 2013-03-20 15:54:03 PDT 
Comment on attachment 193963 [details]
Patch

ok
Comment 3 WebKit Review Bot 2013-03-20 17:12:00 PDT 
Comment on attachment 193963 [details]
Patch

Clearing flags on attachment: 193963

Committed r146417: <http://trac.webkit.org/changeset/146417>
Comment 4 WebKit Review Bot 2013-03-20 17:12:03 PDT 
All reviewed patches have been landed.  Closing bug.