Bug 112747 – Add color profile support for WebP images

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Images

[Urvang Joshi]

Color profile support is being added to WebP in v0.3.0.
This bug regarding adding the same support in WebKit.

[Urvang Joshi]

Created attachment 193932 [details]
Patch

[WebKit Review Bot]

Attachment 193932 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/images/resources/webp-color-profile-lossless.webp', u'LayoutTests/fast/images/resources/webp-color-profile-lossy-alpha.webp', u'LayoutTests/fast/images/resources/webp-color-profile-lossy.webp', u'LayoutTests/fast/images/webp-color-profile-lossless-expected.txt', u'LayoutTests/fast/images/webp-color-profile-lossless.html', u'LayoutTests/fast/images/webp-color-profile-lossy-alpha-expected.txt', u'LayoutTests/fast/images/webp-color-profile-lossy-alpha.html', u'LayoutTests/fast/images/webp-color-profile-lossy-expected.txt', u'LayoutTests/fast/images/webp-color-profile-lossy.html', u'LayoutTests/platform/chromium-mac/fast/images/webp-color-profile-lossless-expected.png', u'LayoutTests/platform/chromium-mac/fast/images/webp-color-profile-lossy-alpha-expected.png', u'LayoutTests/platform/chromium-mac/fast/images/webp-color-profile-lossy-expected.png', u'LayoutTests/platform/chromium-win/fast/images/webp-color-profile-lossless-expected.png', u'LayoutTests/platform/chromium-win/fast/images/webp-color-profile-lossy-alpha-expected.png', u'LayoutTests/platform/chromium-win/fast/images/webp-color-profile-lossy-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp', u'Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h']" exit_code: 1
Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h:61:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h:62:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h:63:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 193932 [details]
Patch

Attachment 193932 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17197548

[Urvang Joshi]

Created attachment 193936 [details]
Patch

[Urvang Joshi]

Created attachment 193938 [details]
Looks like we need to bump up the decoder ABI version in conditional

[WebKit Review Bot]

Comment on attachment 193938 [details]
Looks like we need to bump up the decoder ABI version in conditional

Attachment 193938 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17257094

New failing tests:
platform/chromium/virtual/deferred/fast/images/webp-color-profile-lossy-alpha.html
fast/images/webp-color-profile-lossy.html
platform/chromium/virtual/deferred/fast/images/webp-color-profile-lossless.html
fast/images/webp-color-profile-lossless.html
fast/images/webp-color-profile-lossy-alpha.html
platform/chromium/virtual/deferred/fast/images/webp-color-profile-lossy.html

[Urvang Joshi]

The failing tests are due to the the 'Depends-on' change (https://bugs.webkit.org/show_bug.cgi?id=112761) being pending.

[noel gordon]

This code doesn't compile after libewebp landed in webkit in bug 113184.  As discussed, I will take over and complete the remaining tasks. Opened bug 113184 for that.  Closing this bug (wont fix).

[Darin Adler]

Comment on attachment 193938 [details]
Looks like we need to bump up the decoder ABI version in conditional

If someone wants a newer version of the WebP decoder in WebKit I think a good way would be to get the latest version from Blink project. This patch is old enough that it still has chromium layout test changes in it, so we can’t take this patch as is.