Bug 112736 - GenerateHashValue should be usable outside CodeGeneratorJS.pm
Summary: GenerateHashValue should be usable outside CodeGeneratorJS.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 112303
  Show dependency treegraph
 
Reported: 2013-03-19 12:38 PDT by Adam Barth
Modified: 2013-03-19 13:48 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.65 KB, patch)
2013-03-19 12:41 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (7.67 KB, patch)
2013-03-19 12:59 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-03-19 12:38:49 PDT
GenerateHashValue should be usable outside CodeGeneratorJS.pm
Comment 1 Adam Barth 2013-03-19 12:41:50 PDT
Created attachment 193897 [details]
Patch
Comment 2 Benjamin Poulain 2013-03-19 12:49:37 PDT
Comment on attachment 193897 [details]
Patch

No problem with this.
But this Perl GenerateHashValue should die. We should have a compile time Hash function in C++ instead.
Comment 3 Benjamin Poulain 2013-03-19 12:51:29 PDT
Hum, maybe name is StringHasher for consistency with WTF?
Comment 4 Adam Barth 2013-03-19 12:59:29 PDT
Created attachment 193902 [details]
Patch for landing
Comment 5 Eric Seidel (no email) 2013-03-19 13:00:57 PDT
(In reply to comment #2)
> (From update of attachment 193897 [details])
> No problem with this.
> But this Perl GenerateHashValue should die. We should have a compile time Hash function in C++ instead.

That's possible!?

http://stackoverflow.com/questions/2111667/compile-time-string-hashing
Comment 6 WebKit Review Bot 2013-03-19 13:48:00 PDT
Comment on attachment 193902 [details]
Patch for landing

Clearing flags on attachment: 193902

Committed r146253: <http://trac.webkit.org/changeset/146253>
Comment 7 WebKit Review Bot 2013-03-19 13:48:03 PDT
All reviewed patches have been landed.  Closing bug.