WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
112736
GenerateHashValue should be usable outside CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112736
Summary
GenerateHashValue should be usable outside CodeGeneratorJS.pm
Adam Barth
Reported
2013-03-19 12:38:49 PDT
GenerateHashValue should be usable outside CodeGeneratorJS.pm
Attachments
Patch
(7.65 KB, patch)
2013-03-19 12:41 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Patch for landing
(7.67 KB, patch)
2013-03-19 12:59 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2013-03-19 12:41:50 PDT
Created
attachment 193897
[details]
Patch
Benjamin Poulain
Comment 2
2013-03-19 12:49:37 PDT
Comment on
attachment 193897
[details]
Patch No problem with this. But this Perl GenerateHashValue should die. We should have a compile time Hash function in C++ instead.
Benjamin Poulain
Comment 3
2013-03-19 12:51:29 PDT
Hum, maybe name is StringHasher for consistency with WTF?
Adam Barth
Comment 4
2013-03-19 12:59:29 PDT
Created
attachment 193902
[details]
Patch for landing
Eric Seidel (no email)
Comment 5
2013-03-19 13:00:57 PDT
(In reply to
comment #2
)
> (From update of
attachment 193897
[details]
) > No problem with this. > But this Perl GenerateHashValue should die. We should have a compile time Hash function in C++ instead.
That's possible!?
http://stackoverflow.com/questions/2111667/compile-time-string-hashing
WebKit Review Bot
Comment 6
2013-03-19 13:48:00 PDT
Comment on
attachment 193902
[details]
Patch for landing Clearing flags on attachment: 193902 Committed
r146253
: <
http://trac.webkit.org/changeset/146253
>
WebKit Review Bot
Comment 7
2013-03-19 13:48:03 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug