Bug 112727 - [GTK] Add WebCoreHTML to the gyp build
Summary: [GTK] Add WebCoreHTML to the gyp build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on: 112638
Blocks: 112737
  Show dependency tree / graph
 
Reported: 2013-03-19 11:43 PDT by Martin Robinson
Modified: 2013-03-25 09:27 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.12 KB, patch)
2013-03-19 11:46 PDT, Martin Robinson 		thakis: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-03-19 11:43:55 PDT 
WebCoreHTML includes all the HTML files. HTML is useful for a web content rendering engine.
Comment 1 Martin Robinson 2013-03-19 11:46:58 PDT 
Created attachment 193883 [details]
Patch
Comment 2 Nico Weber 2013-03-19 20:25:17 PDT 
Comment on attachment 193883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193883&action=review

Makes sense.

> Source/WebCore/WebCore.gyp/WebCoreGTK.gyp:921
> +      'type': 'none',

Does linking to a none target that depends on two static_library targets do the right thing? (i.e. link in the two static libraries)
Comment 3 Martin Robinson 2013-03-22 16:50:13 PDT 
Committed r146680: <http://trac.webkit.org/changeset/146680>
Comment 4 Martin Robinson 2013-03-25 09:27:27 PDT 
(In reply to comment #2)
 
> > Source/WebCore/WebCore.gyp/WebCoreGTK.gyp:921
> > +      'type': 'none',
> 
> Does linking to a none target that depends on two static_library targets do the right thing? (i.e. link in the two static libraries)

Hrm. I haven't built out to libwebkit (I'm pretty close now though), but this seems to be how the Chromium build is structured.