Bug 112722 - Merge MainResourceLoader's SubstituteData loading + others into DocumentLoader
Summary: Merge MainResourceLoader's SubstituteData loading + others into DocumentLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks: 104969 112811
  Show dependency tree / graph
 
Reported: 2013-03-19 11:27 PDT by Nate Chapin
Modified: 2013-03-21 08:49 PDT (History)
9 users (show)

See Also:

Attachments
patch (21.66 KB, patch)
2013-03-19 11:36 PDT, Nate Chapin 		no flags Details | Formatted Diff | Diff
Fix compile error (21.68 KB, patch)
2013-03-19 11:48 PDT, Nate Chapin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2013-03-19 11:27:22 PDT 
Others include:
* MainResourceLoader's error handling into DocumentLoader::mainReceivedError()
* MainResourceLoader::cancel into DocumentLoader::cancelMainResourceLoad
* m_identifierForLoadWithoutResourceLoader handling, plus remaining synthesized ResourceLoadNotifier callbacks.
Comment 1 Nate Chapin 2013-03-19 11:36:39 PDT 
Created attachment 193878 [details]
patch
Comment 2 Nate Chapin 2013-03-19 11:48:23 PDT 
Created attachment 193885 [details]
Fix compile error
Comment 3 Antti Koivisto 2013-03-19 12:02:54 PDT 
Comment on attachment 193885 [details]
Fix compile error

r=me
Comment 4 WebKit Review Bot 2013-03-19 12:42:06 PDT 
Comment on attachment 193885 [details]
Fix compile error

Clearing flags on attachment: 193885

Committed r146239: <http://trac.webkit.org/changeset/146239>
Comment 5 WebKit Review Bot 2013-03-19 12:42:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryosuke Niwa 2013-03-19 13:09:39 PDT 
Mac build fix landed in http://trac.webkit.org/changeset/146242.
Comment 7 Csaba Osztrogonác 2013-03-19 16:59:49 PDT 
(In reply to comment #4)
> (From update of attachment 193885 [details])
> Clearing flags on attachment: 193885
> 
> Committed r146239: <http://trac.webkit.org/changeset/146239>

It made 60 tests crash on Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/28194

cc-ing Qt folks for investigation
Comment 8 Alexey Proskuryakov 2013-03-20 09:43:34 PDT 
This also caused bug 112811.
Comment 9 Nate Chapin 2013-03-21 08:34:25 PDT 
(In reply to comment #7)
> (In reply to comment #4)
> > (From update of attachment 193885 [details] [details])
> > Clearing flags on attachment: 193885
> > 
> > Committed r146239: <http://trac.webkit.org/changeset/146239>
> 
> It made 60 tests crash on Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/28194
> 
> cc-ing Qt folks for investigation

Are these tests still crashing? I'd be happy to help diagnose if you have a stack trace.
Comment 10 Csaba Osztrogonác 2013-03-21 08:40:16 PDT 
(In reply to comment #9)
> > It made 60 tests crash on Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/28194
> > 
> > cc-ing Qt folks for investigation
> 
> Are these tests still crashing? I'd be happy to help diagnose if you have a stack trace.

No, the crashes went away somewhere between r146261-r146283.
Comment 11 Nate Chapin 2013-03-21 08:49:00 PDT 
(In reply to comment #10)
> (In reply to comment #9)
> > > It made 60 tests crash on Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/28194
> > > 
> > > cc-ing Qt folks for investigation
> > 
> > Are these tests still crashing? I'd be happy to help diagnose if you have a stack trace.
> 
> No, the crashes went away somewhere between r146261-r146283.

Ah, yeah, I fixed a bunch of chromium asserts in http://trac.webkit.org/changeset/146267, which probably had the same root issue.

Thanks!