Bug 112710 - Web Inspector: Remove remainings of CSS-based console message filtering.
Summary: Web Inspector: Remove remainings of CSS-based console message filtering.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 113321
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-19 10:05 PDT by Dmitry Zvorygin
Modified: 2014-12-01 14:00 PST (History)
13 users (show)

See Also:

Attachments
Patch (12.88 KB, patch)
2013-03-19 10:58 PDT, Dmitry Zvorygin 		no flags Details | Formatted Diff | Diff
Patch (14.37 KB, patch)
2013-03-20 01:34 PDT, Dmitry Zvorygin 		no flags Details | Formatted Diff | Diff
Patch (14.37 KB, patch)
2013-03-21 08:15 PDT, Dmitry Zvorygin 		no flags Details | Formatted Diff | Diff
Patch (17.70 KB, patch)
2013-03-26 08:47 PDT, Dmitry Zvorygin 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Zvorygin 2013-03-19 10:05:27 PDT 
Remove remainings of non-optimal CSS-based console message filtering.
Comment 1 Dmitry Zvorygin 2013-03-19 10:58:13 PDT 
Created attachment 193863 [details]
Patch
Comment 2 Build Bot 2013-03-19 12:07:07 PDT 
Comment on attachment 193863 [details]
Patch

Attachment 193863 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17179373

New failing tests:
inspector/console/console-preserve-log.html
Comment 3 WebKit Review Bot 2013-03-19 12:24:46 PDT 
Comment on attachment 193863 [details]
Patch

Attachment 193863 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17238280

New failing tests:
inspector/console/console-preserve-log.html
Comment 4 WebKit Review Bot 2013-03-19 13:25:09 PDT 
Comment on attachment 193863 [details]
Patch

Attachment 193863 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17215640

New failing tests:
inspector/console/console-preserve-log.html
Comment 5 Build Bot 2013-03-19 18:27:30 PDT 
Comment on attachment 193863 [details]
Patch

Attachment 193863 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17235203

New failing tests:
inspector/console/console-preserve-log.html
Comment 6 Pavel Feldman 2013-03-20 00:38:39 PDT 
Comment on attachment 193863 [details]
Patch

r- for the tests failure
Comment 7 Dmitry Zvorygin 2013-03-20 01:34:18 PDT 
Created attachment 193998 [details]
Patch
Comment 8 Dmitry Zvorygin 2013-03-20 01:35:46 PDT 
Fixed broken test.
Comment 9 Pavel Feldman 2013-03-20 23:14:31 PDT 
Comment on attachment 193998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193998&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:-274
> -            if (target.hasStyleClass("selected")) {

Why did this change?

> Source/WebCore/inspector/front-end/ConsoleView.js:-288
> -        if (!selectMultiple) {

This seems to ruin the diff. Can you leave existing condition nesting?

> Source/WebCore/inspector/front-end/ConsoleView.js:539
> +        return (!message.url || !this._messageURLFilters[message.url]) && (!message.level || this._messageLevelFilters.indexOf(message.level) != -1);

This might get a bit expensive - consider using an object for faster lookup.

> Source/WebCore/inspector/front-end/ConsoleView.js:774
> + * @param wasThrown

You should specify types for parameters and list them in proper order.
Comment 10 Dmitry Zvorygin 2013-03-21 08:15:42 PDT 
Created attachment 194264 [details]
Patch
Comment 11 Pavel Feldman 2013-03-22 08:31:49 PDT 
Comment on attachment 194264 [details]
Patch

I'd like to test it manually before landing.
Comment 12 Dmitry Zvorygin 2013-03-26 08:47:02 PDT 
Created attachment 195093 [details]
Patch
Comment 13 WebKit Review Bot 2013-03-26 10:15:10 PDT 
Comment on attachment 195093 [details]
Patch

Clearing flags on attachment: 195093

Committed r146901: <http://trac.webkit.org/changeset/146901>
Comment 14 WebKit Review Bot 2013-03-26 10:15:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 15 WebKit Review Bot 2013-03-26 10:22:30 PDT 
Re-opened since this is blocked by bug 113321