Bug 112710 – Web Inspector: Remove remainings of CSS-based console message filtering.

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Dmitry Zvorygin]

Remove remainings of non-optimal CSS-based console message filtering.

[Dmitry Zvorygin]

Created attachment 193863 [details]
Patch

[Build Bot]

Comment on attachment 193863 [details]
Patch

Attachment 193863 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17179373

New failing tests:
inspector/console/console-preserve-log.html

[WebKit Review Bot]

Comment on attachment 193863 [details]
Patch

Attachment 193863 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17238280

New failing tests:
inspector/console/console-preserve-log.html

[WebKit Review Bot]

Comment on attachment 193863 [details]
Patch

Attachment 193863 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17215640

New failing tests:
inspector/console/console-preserve-log.html

[Build Bot]

Comment on attachment 193863 [details]
Patch

Attachment 193863 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17235203

New failing tests:
inspector/console/console-preserve-log.html

[Pavel Feldman]

Comment on attachment 193863 [details]
Patch

r- for the tests failure

[Dmitry Zvorygin]

Created attachment 193998 [details]
Patch

[Dmitry Zvorygin]

Fixed broken test.

[Pavel Feldman]

Comment on attachment 193998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193998&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:-274
> -            if (target.hasStyleClass("selected")) {

Why did this change?

> Source/WebCore/inspector/front-end/ConsoleView.js:-288
> -        if (!selectMultiple) {

This seems to ruin the diff. Can you leave existing condition nesting?

> Source/WebCore/inspector/front-end/ConsoleView.js:539
> +        return (!message.url || !this._messageURLFilters[message.url]) && (!message.level || this._messageLevelFilters.indexOf(message.level) != -1);

This might get a bit expensive - consider using an object for faster lookup.

> Source/WebCore/inspector/front-end/ConsoleView.js:774
> + * @param wasThrown

You should specify types for parameters and list them in proper order.

[Dmitry Zvorygin]

Created attachment 194264 [details]
Patch

[Pavel Feldman]

Comment on attachment 194264 [details]
Patch

I'd like to test it manually before landing.

[Dmitry Zvorygin]

Created attachment 195093 [details]
Patch

[WebKit Review Bot]

Comment on attachment 195093 [details]
Patch

Clearing flags on attachment: 195093

Committed r146901: <http://trac.webkit.org/changeset/146901>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 113321