Bug 112704 – [Qt] Enable kerning by default

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Allan Sandfeld Jensen]

Since kerning is now possible in the fast font-path, we should enable kerning by default as we do in the rest of Qt.

[Allan Sandfeld Jensen]

Created attachment 193858 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 193858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193858&action=review

> Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.cpp:77
> +        WebCore::Font::setDefaultTypesettingFeatures(WebCore::Kerning);

Comment please :)

[Allan Sandfeld Jensen]

Created attachment 194014 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 194014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194014&action=review

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:91
> +    DumpRenderTreeSupportQt::setDefaultTypesettingFeatures(0);

This is a bit stretched, passing an int knowing that the caller will call it with 0 and won't have to include WebCore headers.
DumpRenderTreeSupportQt doesn't seem to expose any other WebCore type that way, so maybe this should be exposed as a "disableAll" method or as individual bool settings for kerning and ligatures independently?

[Jocelyn Turcotte]

Pierre, I'd also like to know if this looks fine to you, could you have a look?

[Allan Sandfeld Jensen]

(In reply to comment #4)
> (From update of attachment 194014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=194014&action=review
> 
> > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:91
> > +    DumpRenderTreeSupportQt::setDefaultTypesettingFeatures(0);
> 
> This is a bit stretched, passing an int knowing that the caller will call it with 0 and won't have to include WebCore headers.
> DumpRenderTreeSupportQt doesn't seem to expose any other WebCore type that way, so maybe this should be exposed as a "disableAll" method or as individual bool settings for kerning and ligatures independently?

I will make it disable all. This is all we really need since the layout expectations simply expects how it used to be, with all off by default.

[Allan Sandfeld Jensen]

Created attachment 194015 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 194015 [details]
Patch

14:32 < elproxy> LGTM.
r=me

[Allan Sandfeld Jensen]

Committed r146340: <http://trac.webkit.org/changeset/146340>