Bug 112693 – Web Inspector: move OverviewGrid and OverviewWindow into separate file.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

the third patch for the bug "Web Inspector: meta bug: extract OverviewGrid from TimelineOverviewPane"

It just movies the OverviewGrid into its own file.

[Ilya Tikhonovsky]

Created attachment 193813 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 193813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193813&action=review

> Source/WebCore/ChangeLog:9
> +        It just movies the OverviewGrid and the related classes into its own file.

movies -> moves

> Source/WebCore/inspector/compile-front-end.py:138
> +            "OverviewGrid.js",

You should also add this to .vcproj and .gypi files.

> Source/WebCore/inspector/front-end/OverviewGrid.js:2
> + * Copyright (C) 2012 Google Inc. All rights reserved.

2013

> Source/WebCore/inspector/front-end/OverviewGrid.js:35
> +WebInspector.OverviewGrid = function(prefix)

Maybe call it OverviewPane?

[Ilya Tikhonovsky]

Created attachment 193821 [details]
Patch

[Ilya Tikhonovsky]

(In reply to comment #2)
> (From update of attachment 193813 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193813&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        It just movies the OverviewGrid and the related classes into its own file.
> 
> movies -> moves

done

> 
> > Source/WebCore/inspector/compile-front-end.py:138
> > +            "OverviewGrid.js",
> 
> You should also add this to .vcproj and .gypi files.

done

> 
> > Source/WebCore/inspector/front-end/OverviewGrid.js:2
> > + * Copyright (C) 2012 Google Inc. All rights reserved.
> 
> 2013

done

> 
> > Source/WebCore/inspector/front-end/OverviewGrid.js:35
> > +WebInspector.OverviewGrid = function(prefix)
> 
> Maybe call it OverviewPane?

The wording is bad. I would like to change it in the next patch.
But it is not a pane. It is a component that could be used anywhere.
I'm going to use it in FlameChartOverviewPane and it is a part of TimelineOverviewPane.

If grid suffix is ok it could be OverviewTimelineGrid.

[Ilya Tikhonovsky]

Committed r146204: <http://trac.webkit.org/changeset/146204>